From 4e8de55de012cf2fbc13f3255727e833a6950d35 Mon Sep 17 00:00:00 2001
From: Sergei Tikhomirov <sergey.s.tikhomirov@gmail.com>
Date: Tue, 15 Jul 2025 15:34:57 +0200
Subject: [PATCH] use new Lightpush status type in reputation tests

---
 tests/incentivization/test_poc_reputation.nim | 18 +++++++++---------
 waku/waku_lightpush/common.nim                |  1 +
 2 files changed, 10 insertions(+), 9 deletions(-)

diff --git a/tests/incentivization/test_poc_reputation.nim b/tests/incentivization/test_poc_reputation.nim
index 95348874f..08e0b5ca0 100644
--- a/tests/incentivization/test_poc_reputation.nim
+++ b/tests/incentivization/test_poc_reputation.nim
@@ -31,37 +31,37 @@ suite "Waku Incentivization PoC Reputation":
 
   test "incentivization PoC: reputation: evaluate LightPushResponse valid":
     let validLightLightPushResponse =
-      LightPushResponse(requestId: "", statusCode: LightpushStatusCode.SUCCESS.uint32)
+      LightPushResponse(requestId: "", statusCode: LightPushSuccessCode.SUCCESS)
     # We expect evaluateResponse to return GoodResponse if isSuccess is true
     check evaluateResponse(validLightLightPushResponse) == GoodResponse
 
   test "incentivization PoC: reputation: evaluate LightPushResponse invalid":
     let invalidLightLightPushResponse = LightPushResponse(
-      requestId: "", statusCode: LightpushStatusCode.SERVICE_NOT_AVAILABLE.uint32
+      requestId: "", statusCode: LightPushErrorCode.SERVICE_NOT_AVAILABLE
     )
     check evaluateResponse(invalidLightLightPushResponse) == BadResponse
 
   test "incentivization PoC: reputation: evaluate LightPushResponse neutral - payment required":
     let neutralLightPushResponse = LightPushResponse(
-      requestId: "", statusCode: LightpushStatusCode.PAYMENT_REQUIRED.uint32
+      requestId: "", statusCode: LightPushErrorCode.PAYMENT_REQUIRED
     )
     check evaluateResponse(neutralLightPushResponse) == NeutralResponse
 
   test "incentivization PoC: reputation: evaluate LightPushResponse bad - no peers":
     let badLightPushResponse = LightPushResponse(
-      requestId: "", statusCode: LightpushStatusCode.NO_PEERS_TO_RELAY.uint32
+      requestId: "", statusCode: LightPushErrorCode.NO_PEERS_TO_RELAY
     )
     check evaluateResponse(badLightPushResponse) == BadResponse
 
   test "incentivization PoC: reputation: updateReputationFromResponse valid":
     let validResp =
-      LightPushResponse(requestId: "", statusCode: LightpushStatusCode.SUCCESS.uint32)
+      LightPushResponse(requestId: "", statusCode: LightPushSuccessCode.SUCCESS)
     manager.updateReputationFromResponse(peerId1, validResp)
     check manager.getReputation(peerId1) == some(true)
 
   test "incentivization PoC: reputation: updateReputationFromResponse invalid":
     let invalidResp = LightPushResponse(
-      requestId: "", statusCode: LightpushStatusCode.SERVICE_NOT_AVAILABLE.uint32
+      requestId: "", statusCode: LightPushErrorCode.SERVICE_NOT_AVAILABLE
     )
     manager.updateReputationFromResponse(peerId1, invalidResp)
     check manager.getReputation(peerId1) == some(false)
@@ -73,7 +73,7 @@ suite "Waku Incentivization PoC Reputation":
     
     # Send a neutral response (payment required)
     let neutralResp = LightPushResponse(
-      requestId: "", statusCode: LightpushStatusCode.PAYMENT_REQUIRED.uint32
+      requestId: "", statusCode: LightPushErrorCode.PAYMENT_REQUIRED
     )
     manager.updateReputationFromResponse(peerId1, neutralResp)
     
@@ -87,7 +87,7 @@ suite "Waku Incentivization PoC Reputation":
     
     # Send a neutral response (payment required)
     let neutralResp = LightPushResponse(
-      requestId: "", statusCode: LightpushStatusCode.PAYMENT_REQUIRED.uint32
+      requestId: "", statusCode: LightPushErrorCode.PAYMENT_REQUIRED
     )
     manager.updateReputationFromResponse(peerId1, neutralResp)
     
@@ -100,7 +100,7 @@ suite "Waku Incentivization PoC Reputation":
     
     # Send a neutral response (payment required)
     let neutralResp = LightPushResponse(
-      requestId: "", statusCode: LightpushStatusCode.PAYMENT_REQUIRED.uint32
+      requestId: "", statusCode: LightPushErrorCode.PAYMENT_REQUIRED
     )
     manager.updateReputationFromResponse(peerId1, neutralResp)
     
diff --git a/waku/waku_lightpush/common.nim b/waku/waku_lightpush/common.nim
index f2687834e..f810dd904 100644
--- a/waku/waku_lightpush/common.nim
+++ b/waku/waku_lightpush/common.nim
@@ -11,6 +11,7 @@ const LightPushSuccessCode* = (SUCCESS: LightPushStatusCode(200))
 
 const LightPushErrorCode* = (
   BAD_REQUEST: LightPushStatusCode(400),
+  PAYMENT_REQUIRED: LightPushStatusCode(402),
   PAYLOAD_TOO_LARGE: LightPushStatusCode(413),
   INVALID_MESSAGE: LightPushStatusCode(420),
   UNSUPPORTED_PUBSUB_TOPIC: LightPushStatusCode(421),