From b92a0ef26203ba77d6ec5d68fe8590f7f36324aa Mon Sep 17 00:00:00 2001 From: darshankabariya Date: Tue, 28 Apr 2026 15:37:37 +0530 Subject: [PATCH 1/6] feat: initial changes --- waku/waku_rln_relay/constants.nim | 2 ++ 1 file changed, 2 insertions(+) diff --git a/waku/waku_rln_relay/constants.nim b/waku/waku_rln_relay/constants.nim index 3e4757537..8b365ed68 100644 --- a/waku/waku_rln_relay/constants.nim +++ b/waku/waku_rln_relay/constants.nim @@ -7,6 +7,8 @@ import ../waku_keystore # Acceptable roots for merkle root validation of incoming messages const AcceptableRootWindowSize* = 50 +const DummyConstant* = 50 + # RLN membership key and index files path const RlnCredentialsFilename* = "rlnCredentials.txt" From a9f241e0325f95207478ade5b4d94c3d03316760 Mon Sep 17 00:00:00 2001 From: darshankabariya Date: Wed, 29 Apr 2026 03:22:02 +0530 Subject: [PATCH 2/6] feat: us prebuilt nimble to avoid koch --- .github/workflows/windows-build.yml | 10 ++++++++-- waku/waku_rln_relay/constants.nim | 2 -- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/.github/workflows/windows-build.yml b/.github/workflows/windows-build.yml index 50f1602cd..f7c455a04 100644 --- a/.github/workflows/windows-build.yml +++ b/.github/workflows/windows-build.yml @@ -75,10 +75,16 @@ jobs: repo-token: ${{ secrets.GITHUB_TOKEN }} - name: Install Nimble ${{ env.NIMBLE_VERSION }} + # Use the prebuilt Windows binary instead of `nimble install nimble@...`, + # which triggers a koch self-bootstrap that races Windows Defender on + # bin\nim.exe and fails with "Access is denied". run: | - export PATH="$GITHUB_WORKSPACE/.nim_runtime/bin:$PATH" - cd /tmp && nimble install "nimble@${{ env.NIMBLE_VERSION }}" -y + mkdir -p "$HOME/.nimble/bin" + curl -fsSL -o /tmp/nimble.zip \ + "https://github.com/nim-lang/nimble/releases/download/v${{ env.NIMBLE_VERSION }}/nimble-windows_x64.zip" + unzip -o /tmp/nimble.zip -d "$HOME/.nimble/bin" echo "$HOME/.nimble/bin" >> $GITHUB_PATH + "$HOME/.nimble/bin/nimble.exe" --version - name: Patch nimble.lock for Windows nim checksum # nimble.exe uses Windows Git (core.autocrlf=true by default), which converts LF→CRLF diff --git a/waku/waku_rln_relay/constants.nim b/waku/waku_rln_relay/constants.nim index 8b365ed68..3e4757537 100644 --- a/waku/waku_rln_relay/constants.nim +++ b/waku/waku_rln_relay/constants.nim @@ -7,8 +7,6 @@ import ../waku_keystore # Acceptable roots for merkle root validation of incoming messages const AcceptableRootWindowSize* = 50 -const DummyConstant* = 50 - # RLN membership key and index files path const RlnCredentialsFilename* = "rlnCredentials.txt" From 03239f3521a2c42e38e0d67c8f839c2ab9d09bc4 Mon Sep 17 00:00:00 2001 From: darshankabariya Date: Wed, 29 Apr 2026 12:39:08 +0530 Subject: [PATCH 3/6] feat: add timout --- .github/workflows/windows-build.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/windows-build.yml b/.github/workflows/windows-build.yml index f7c455a04..afa040200 100644 --- a/.github/workflows/windows-build.yml +++ b/.github/workflows/windows-build.yml @@ -107,6 +107,7 @@ jobs: run: mkdir -p tmp - name: Building wakunode2.exe + timeout-minutes: 45 run: | export PATH="$GITHUB_WORKSPACE/.nim_runtime/bin:$HOME/.nimble/bin:$PATH" make wakunode2 V=3 -j${{ env.NPROC }} @@ -129,4 +130,4 @@ jobs: else echo "Build failed: libwaku.dll not found" exit 1 - fi \ No newline at end of file + fi From 5e39e7727a76a414c9be857ff2d784a8df9a5bc5 Mon Sep 17 00:00:00 2001 From: darshankabariya Date: Wed, 29 Apr 2026 13:46:02 +0530 Subject: [PATCH 4/6] feat: give access local depeneency --- Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index be9e14027..31b6e6a11 100644 --- a/Makefile +++ b/Makefile @@ -218,7 +218,7 @@ testwaku: | $(NIMBLEDEPS_STAMP) build rln-deps librln wakunode2: | $(NIMBLEDEPS_STAMP) build deps librln echo -e $(BUILD_MSG) "build/$@" && \ - nimble wakunode2 + nimble --localdeps wakunode2 benchmarks: | $(NIMBLEDEPS_STAMP) build deps librln echo -e $(BUILD_MSG) "build/$@" && \ @@ -425,7 +425,7 @@ else ifeq ($(detected_OS),Linux) endif libwaku: | $(NIMBLEDEPS_STAMP) librln - nimble --verbose libwaku$(BUILD_COMMAND) waku.nimble + nimble --localdeps --verbose libwaku$(BUILD_COMMAND) waku.nimble liblogosdelivery: | $(NIMBLEDEPS_STAMP) librln nimble --verbose liblogosdelivery$(BUILD_COMMAND) waku.nimble From 3ee1a88408ed3498fda64717773271d5499bb7c4 Mon Sep 17 00:00:00 2001 From: darshankabariya Date: Wed, 29 Apr 2026 15:14:31 +0530 Subject: [PATCH 5/6] feat: revart chanegs and use nimbledeps path --- .github/workflows/windows-build.yml | 1 + Makefile | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/windows-build.yml b/.github/workflows/windows-build.yml index afa040200..f5bdbcfa7 100644 --- a/.github/workflows/windows-build.yml +++ b/.github/workflows/windows-build.yml @@ -22,6 +22,7 @@ jobs: env: MSYSTEM: MINGW64 + NIMBLE_DIR: ${{ github.workspace }}/nimbledeps steps: - name: Checkout code diff --git a/Makefile b/Makefile index 31b6e6a11..be9e14027 100644 --- a/Makefile +++ b/Makefile @@ -218,7 +218,7 @@ testwaku: | $(NIMBLEDEPS_STAMP) build rln-deps librln wakunode2: | $(NIMBLEDEPS_STAMP) build deps librln echo -e $(BUILD_MSG) "build/$@" && \ - nimble --localdeps wakunode2 + nimble wakunode2 benchmarks: | $(NIMBLEDEPS_STAMP) build deps librln echo -e $(BUILD_MSG) "build/$@" && \ @@ -425,7 +425,7 @@ else ifeq ($(detected_OS),Linux) endif libwaku: | $(NIMBLEDEPS_STAMP) librln - nimble --localdeps --verbose libwaku$(BUILD_COMMAND) waku.nimble + nimble --verbose libwaku$(BUILD_COMMAND) waku.nimble liblogosdelivery: | $(NIMBLEDEPS_STAMP) librln nimble --verbose liblogosdelivery$(BUILD_COMMAND) waku.nimble From 2091f3947a22cb2038c21b5bc99319eb2ad71e80 Mon Sep 17 00:00:00 2001 From: darshankabariya Date: Wed, 29 Apr 2026 17:48:50 +0530 Subject: [PATCH 6/6] feat: attach path --- .github/workflows/windows-build.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/windows-build.yml b/.github/workflows/windows-build.yml index f5bdbcfa7..9ac96e2fe 100644 --- a/.github/workflows/windows-build.yml +++ b/.github/workflows/windows-build.yml @@ -98,7 +98,7 @@ jobs: - name: Install nimble deps if: steps.cache-nimbledeps.outputs.cache-hit != 'true' run: | - export PATH="$GITHUB_WORKSPACE/.nim_runtime/bin:$HOME/.nimble/bin:$PATH" + export PATH="$HOME/.nimble/bin:$GITHUB_WORKSPACE/.nim_runtime/bin:$PATH" nimble setup --localdeps -y make rebuild-nat-libs-nimbledeps CC=gcc make rebuild-bearssl-nimbledeps CC=gcc @@ -110,12 +110,12 @@ jobs: - name: Building wakunode2.exe timeout-minutes: 45 run: | - export PATH="$GITHUB_WORKSPACE/.nim_runtime/bin:$HOME/.nimble/bin:$PATH" + export PATH="$HOME/.nimble/bin:$GITHUB_WORKSPACE/.nim_runtime/bin:$PATH" make wakunode2 V=3 -j${{ env.NPROC }} - name: Building libwaku.dll run: | - export PATH="$GITHUB_WORKSPACE/.nim_runtime/bin:$HOME/.nimble/bin:$PATH" + export PATH="$HOME/.nimble/bin:$GITHUB_WORKSPACE/.nim_runtime/bin:$PATH" make libwaku STATIC=0 V=1 -j - name: Check Executable