From 37caab8a13f1ccdedfe9e5283f36836c04f0d252 Mon Sep 17 00:00:00 2001
From: G <28568419+s1fr0@users.noreply.github.com>
Date: Mon, 10 Oct 2022 19:35:43 +0200
Subject: [PATCH] fix(rln): fix encoding to LE for idcommitments (#1256)

---
 waku/v2/protocol/waku_rln_relay/waku_rln_relay_utils.nim | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/waku/v2/protocol/waku_rln_relay/waku_rln_relay_utils.nim b/waku/v2/protocol/waku_rln_relay/waku_rln_relay_utils.nim
index 6e29492b3..526bde8c6 100644
--- a/waku/v2/protocol/waku_rln_relay/waku_rln_relay_utils.nim
+++ b/waku/v2/protocol/waku_rln_relay/waku_rln_relay_utils.nim
@@ -178,11 +178,11 @@ proc createRLNInstance*(d: int = MerkleTreeDepth): RLNResult {.raises: [Defect,
   return res
 
 proc toUInt256*(idCommitment: IDCommitment): UInt256 =
-  let pk = UInt256.fromBytesBE(idCommitment)
+  let pk = UInt256.fromBytesLE(idCommitment)
   return pk
 
 proc toIDCommitment*(idCommitmentUint: UInt256): IDCommitment =
-  let pk = IDCommitment(idCommitmentUint.toBytesBE())
+  let pk = IDCommitment(idCommitmentUint.toBytesLE())
   return pk
 
 proc toMembershipIndex(v: UInt256): MembershipIndex =
@@ -233,6 +233,7 @@ proc register*(idComm: IDCommitment, ethAccountAddress: Address, ethAccountPrivK
   debug "tx log data", arguments=arguments
   let 
     argumentsBytes = arguments.hexToSeqByte()
+    # In TX log data, uints are encoded in big endian
     eventIdCommUint = UInt256.fromBytesBE(argumentsBytes[0..31])
     eventIndex =  UInt256.fromBytesBE(argumentsBytes[32..^1])
     eventIdComm = eventIdCommUint.toIDCommitment()