From 350929c6eb2b549e0ed6af389a03a1dc8cb2936f Mon Sep 17 00:00:00 2001 From: Sergei Tikhomirov Date: Thu, 6 Mar 2025 11:02:03 +0100 Subject: [PATCH] set reputationEnabled to false by default in config --- tests/waku_lightpush/test_client.nim | 1 - waku/factory/external_config.nim | 3 +-- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/tests/waku_lightpush/test_client.nim b/tests/waku_lightpush/test_client.nim index 5d5553e0a..a46a67210 100644 --- a/tests/waku_lightpush/test_client.nim +++ b/tests/waku_lightpush/test_client.nim @@ -75,7 +75,6 @@ suite "Waku Lightpush Client": server = await newTestWakuLightpushNode(serverSwitch, handler) serverFailsLightpush = await newTestWakuLightpushNode(serverSwitchFailsLightpush, handlerFailsLightpush) - ## FIXME: how to pass reputationEnabled from config to here? should we? client = newTestWakuLightpushClient(clientSwitch, reputationEnabled = true) await allFutures( diff --git a/waku/factory/external_config.nim b/waku/factory/external_config.nim index 9fe05829d..ebb7d8f96 100644 --- a/waku/factory/external_config.nim +++ b/waku/factory/external_config.nim @@ -497,10 +497,9 @@ hence would have reachability issues.""", .}: string ## Reputation config - ## FIXME: should be set to false by default reputationEnabled* {. desc: "Enable client-side reputation for light protocols: true|false", - defaultValue: true, + defaultValue: false, name: "reputation" .}: bool