From 34c197c5cdad1d5787f8f51b66d7e83014e5480b Mon Sep 17 00:00:00 2001 From: Ivan FB <128452529+Ivansete-status@users.noreply.github.com> Date: Fri, 15 May 2026 17:39:38 +0200 Subject: [PATCH] avoid keeping delivery tasks in propagated state when check store is disabled (#3843) --- waku/node/delivery_service/send_service/send_service.nim | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/waku/node/delivery_service/send_service/send_service.nim b/waku/node/delivery_service/send_service/send_service.nim index a3c44bc0c..e6d3a2eda 100644 --- a/waku/node/delivery_service/send_service/send_service.nim +++ b/waku/node/delivery_service/send_service/send_service.nim @@ -225,9 +225,12 @@ proc evaluateAndCleanUp(self: SendService) = it.state != DeliveryState.FailedToDeliver ) - # remove propagated ephemeral messages as no store check is possible + # remove propagated messages when no store confirmation will follow self.taskCache.keepItIf( - not (it.isEphemeral() and it.state == DeliveryState.SuccessfullyPropagated) + not ( + it.state == DeliveryState.SuccessfullyPropagated and + (it.isEphemeral() or not self.checkStoreForMessages) + ) ) proc trySendMessages(self: SendService) {.async.} =