From 3100d86f249081e10ebbb5690bc28462c872387b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Oskar=20Thor=C3=A9n?= Date: Tue, 22 Sep 2020 10:14:39 +0800 Subject: [PATCH] Don't crash on non WakuMessage in rpc subscribe (#175) Instead, log stringified version. (This is used for other PoC right now.) --- waku/node/v2/rpc/wakurpc.nim | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/waku/node/v2/rpc/wakurpc.nim b/waku/node/v2/rpc/wakurpc.nim index 93031eda1..2e656d01e 100644 --- a/waku/node/v2/rpc/wakurpc.nim +++ b/waku/node/v2/rpc/wakurpc.nim @@ -54,11 +54,11 @@ proc setupWakuRPC*(node: WakuNode, rpcsrv: RpcServer) = let msg = WakuMessage.init(data) if msg.isOk(): debug "waku_subscribe handler", msg=msg + var readable_str = cast[string](msg[].payload) + info "Hit subscribe handler", topic=topic, msg=msg[], payload=readable_str else: warn "waku_subscribe decode error", msg=msg - - var readable_str = cast[string](msg[].payload) - info "Hit subscribe handler", topic=topic, msg=msg[], payload=readable_str + info "waku_subscribe raw data string", str=cast[string](data) # XXX: Can we make this context async to use await? discard node.subscribe(topic, handler)