logos-messaging/logos-messaging-nim
1
0
Fork 0
mirror of https://github.com/logos-messaging/logos-messaging-nim.git synced 2026-05-28 13:19:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore(rln-relay): re-enable root validation (#1445)

Browse Source 
* fix(rln-relay): enable root validation

* fix(rln-relay): unused import
This commit is contained in:
Aaryamann Challani 2022-12-05 23:52:54 +05:30 committed by GitHub
parent b56c4340f7
commit 2e0db18cde
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
waku/v2/protocol/waku_rln_relay/protocol_types.nim
View File

@ -7,7 +7,6 @@ import
std/[options, tables, deques], std/[options, tables, deques],
stew/arrayops, stew/arrayops,
chronos, chronos,
stint,
web3, web3,
eth/keys eth/keys
import import

3
waku/v2/protocol/waku_rln_relay/utils.nim
View File

@ -734,11 +734,10 @@ proc validateMessage*(rlnPeer: WakuRLNRelay, msg: WakuMessage,
waku_rln_invalid_messages_total.inc(labelValues=["invalid_epoch"]) waku_rln_invalid_messages_total.inc(labelValues=["invalid_epoch"])
return MessageValidationResult.Invalid return MessageValidationResult.Invalid
## TODO: FIXME after resolving this issue https://github.com/status-im/nwaku/issues/1247
if not rlnPeer.validateRoot(proof.merkleRoot): if not rlnPeer.validateRoot(proof.merkleRoot):
debug "invalid message: provided root does not belong to acceptable window of roots", provided=proof.merkleRoot, validRoots=rlnPeer.validMerkleRoots.mapIt(it.inHex()) debug "invalid message: provided root does not belong to acceptable window of roots", provided=proof.merkleRoot, validRoots=rlnPeer.validMerkleRoots.mapIt(it.inHex())
waku_rln_invalid_messages_total.inc(labelValues=["invalid_root"]) waku_rln_invalid_messages_total.inc(labelValues=["invalid_root"])
# return MessageValidationResult.Invalid return MessageValidationResult.Invalid
# verify the proof # verify the proof
let let