logos-messaging/logos-messaging-nim
1
0
Fork 0
mirror of https://github.com/logos-messaging/logos-messaging-nim.git synced 2026-01-25 01:03:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

handle empty pre-selected peers case due to bad reputation

Browse Source
This commit is contained in:
Sergei Tikhomirov 2025-07-09 15:51:14 +02:00
parent bdd2ed51fd
commit 14698bd9d9
2 changed files with 16 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
waku/incentivization/reputation_manager.nim
View File

@ -1,4 +1,4 @@
import tables, std/options
import tables, std/options, chronicles
import ../waku_lightpush/[rpc, common]
import libp2p/peerid
@ -44,6 +44,8 @@ proc updateReputationFromResponse*(
let respQuality = evaluateResponse(response)
case respQuality
of BadResponse:
debug "Assign bad reputation for peer", peer = peer
manager.setReputation(peer, some(false)) # false => BadRep
of GoodResponse:
debug "Assign good reputation for peer", peer = peer
manager.setReputation(peer, some(true)) # true => GoodRep

15
waku/node/peer_manager/peer_manager.nim
View File

@ -250,10 +250,15 @@ proc selectPeer*(
# If not slotted, we select a random peer for the given protocol
if peers.len > 0:
# if reputation is enabled, filter out bad-reputation peers
debug "Total peers in peerstore:", numPeers = peers.len
debug "Before filtering - total peers:", numPeers = peers.len
var preSelectedPeers =
if pm.reputationManager.isSome():
debug "Reputation enabled: consider only non-negative reputation peers"
for peer in peers:
let rep = try:
pm.reputationManager.get().getReputation(peer.peerId)
except KeyError:
none(bool)
peers.filterIt:
let rep =
try:
@ -263,10 +268,16 @@ proc selectPeer*(
rep == none(bool) or rep == some(true)
else:
peers
debug "Pre-selected peers from peerstore: ", numPeers = preSelectedPeers.len
if preSelectedPeers.len == 0:
return none(RemotePeerInfo)
let selectedPeer = preSelectedPeers[0]
if pm.reputationManager.isSome():
debug "Non-negative reputation peers in peerstore: ", numPeers = preSelectedPeers.len
debug "Selected peer has reputation", reputation = pm.reputationManager.get().getReputation(selectedPeer.peerId)
trace "Got peer from peerstore",
peerId = selectedPeer.peerId, multi = selectedPeer.addrs[0], protocol = proto
return some(selectedPeer)