From a7b61aeb3327f38335c04313ffb0e6d5dab3ce29 Mon Sep 17 00:00:00 2001 From: aya Date: Thu, 24 Oct 2024 13:12:58 +0300 Subject: [PATCH] Adding review comments --- tests/store/test_page_size.py | 2 +- tests/store/test_sorting.py | 2 +- tests/store/test_time_filter.py | 103 ++++++++++++++++---------------- 3 files changed, 54 insertions(+), 53 deletions(-) diff --git a/tests/store/test_page_size.py b/tests/store/test_page_size.py index 42cbea77..0d7fe7bb 100644 --- a/tests/store/test_page_size.py +++ b/tests/store/test_page_size.py @@ -48,7 +48,7 @@ class TestPageSize(StepsStore): page_size = -1 for i in range(10): self.publish_message(message=self.create_message(payload=to_base64(f"Message_{i}"))) - logger.debug(f"requesting stored message with wrong page_size = {page_size}") + logger.debug(f"requesting stored message with wrong page_size = {page_size}") for node in self.store_nodes: store_response = self.get_messages_from_store(node, page_size=page_size) assert len(store_response.messages) == 10, "Message count mismatch" diff --git a/tests/store/test_sorting.py b/tests/store/test_sorting.py index 1e8373aa..fc1990aa 100644 --- a/tests/store/test_sorting.py +++ b/tests/store/test_sorting.py @@ -32,7 +32,7 @@ class TestSorting(StepsStore): message = self.create_message(payload=to_base64(f"Message_{i}")) self.publish_message(message=message) expected_message_hash_list.append(self.compute_message_hash(self.test_pubsub_topic, message)) - logger.debug(f"requesting stored messages with invalid ascending ={ascending}") + logger.debug(f"requesting stored messages with invalid ascending ={ascending}") for node in self.store_nodes: store_response = self.get_messages_from_store(node, ascending=ascending, page_size=2) response_message_hash_list = [] diff --git a/tests/store/test_time_filter.py b/tests/store/test_time_filter.py index a3396fa2..b50735e1 100644 --- a/tests/store/test_time_filter.py +++ b/tests/store/test_time_filter.py @@ -132,6 +132,58 @@ class TestTimeFilter(StepsStore): logger.debug(f"response for wrong time message is {store_response.response}") assert len(store_response.messages) == 0, "got messages with start time after end time !" + def test_time_filter_negative_start_time(self): + for timestamp in self.ts_pass: + message = self.create_message(timestamp=timestamp["value"]) + self.publish_message(message=message) + + start_time = -10000 + logger.debug(f"inquering stored messages with start time {start_time}") + for node in self.store_nodes: + store_response = self.get_messages_from_store(node, page_size=20, start_time=start_time, include_data=True) + logger.debug(f"number of messages stored for " f"start time = {start_time} is {len(store_response.messages)}") + + assert len(store_response.messages) == 6, "number of messages retrieved doesn't match time filter " + + def test_time_filter_zero_start_time(self): + for timestamp in self.ts_pass: + message = self.create_message(timestamp=timestamp["value"]) + self.publish_message(message=message) + start_time = 0 + logger.debug(f"inquering stored messages with start time {start_time}") + for node in self.store_nodes: + store_response = self.get_messages_from_store(node, page_size=20, start_time=start_time, include_data=True) + logger.debug(f"number of messages stored for " f"start time = {start_time} is {len(store_response.messages)}") + + assert len(store_response.messages) == 6, "number of messages retrieved doesn't match time filter " + + def test_time_filter_zero_start_end_time(self): + for timestamp in self.ts_pass: + message = self.create_message(timestamp=timestamp["value"]) + self.publish_message(message=message) + start_time = 0 + end_time = 0 + logger.debug(f"inquering stored messages with start time {start_time}") + for node in self.store_nodes: + store_response = self.get_messages_from_store(node, page_size=20, start_time=start_time, end_time=end_time, include_data=True) + logger.debug(f"number of messages stored for " f"start time = {start_time} is {len(store_response.messages)}") + + assert len(store_response.messages) == 6, "number of messages retrieved doesn't match time filter " + + def test_time_filter_invalid_start_time(self): + for timestamp in self.ts_pass: + message = self.create_message(timestamp=timestamp["value"]) + self.publish_message(message=message) + start_time = "abc" + logger.debug(f"inquering stored messages with start time {start_time}") + try: + for node in self.store_nodes: + store_response = self.get_messages_from_store(node, page_size=20, start_time=start_time, include_data=True) + raise Exception(f" request for stored messages with invalid start time {start_time} is successful") + except Exception as e: + logger.debug(f"invalid start_time cause error {e}") + assert e.args[0].find("Bad Request for url"), "url with wrong start_time is accepted" + def test_time_filter_end_time_now(self): self.ts_pass[3]["value"] = int((datetime.now() + timedelta(seconds=4)).timestamp() * 1e9) start_time = self.ts_pass[0]["value"] @@ -194,54 +246,3 @@ class TestTimeFilter(StepsStore): store_response = self.get_messages_from_store(node, page_size=20, end_time=end_time, include_data=True) logger.debug(f"number of messages stored for " f"end time = {end_time} is {len(store_response.messages)}") assert len(store_response.messages) == 6, "number of messages retrieved doesn't match time filter " - - def test_time_filter_negative_start_time(self): - for timestamp in self.ts_pass: - message = self.create_message(timestamp=timestamp["value"]) - self.publish_message(message=message) - start_time = -10000 - logger.debug(f"inquering stored messages with start time {start_time}") - for node in self.store_nodes: - store_response = self.get_messages_from_store(node, page_size=20, start_time=start_time, include_data=True) - logger.debug(f"number of messages stored for " f"start time = {start_time} is {len(store_response.messages)}") - - assert len(store_response.messages) == 6, "number of messages retrieved doesn't match time filter " - - def test_time_filter_zero_start_time(self): - for timestamp in self.ts_pass: - message = self.create_message(timestamp=timestamp["value"]) - self.publish_message(message=message) - start_time = 0 - logger.debug(f"inquering stored messages with start time {start_time}") - for node in self.store_nodes: - store_response = self.get_messages_from_store(node, page_size=20, start_time=start_time, include_data=True) - logger.debug(f"number of messages stored for " f"start time = {start_time} is {len(store_response.messages)}") - - assert len(store_response.messages) == 6, "number of messages retrieved doesn't match time filter " - - def test_time_filter_zero_start_end_time(self): - for timestamp in self.ts_pass: - message = self.create_message(timestamp=timestamp["value"]) - self.publish_message(message=message) - start_time = 0 - end_time = 0 - logger.debug(f"inquering stored messages with start time {start_time}") - for node in self.store_nodes: - store_response = self.get_messages_from_store(node, page_size=20, start_time=start_time, end_time=end_time, include_data=True) - logger.debug(f"number of messages stored for " f"start time = {start_time} is {len(store_response.messages)}") - - assert len(store_response.messages) == 6, "number of messages retrieved doesn't match time filter " - - def test_time_filter_invalid_start_time(self): - for timestamp in self.ts_pass: - message = self.create_message(timestamp=timestamp["value"]) - self.publish_message(message=message) - start_time = "abc" - logger.debug(f"inquering stored messages with start time {start_time}") - try: - for node in self.store_nodes: - store_response = self.get_messages_from_store(node, page_size=20, start_time=start_time, include_data=True) - raise Exception(f" request for stored messages with invalid start time {start_time} is successful") - except Exception as e: - logger.debug(f"invalid start_time cause error {e}") - assert e.args[0].find("Bad Request for url"), "url with wrong start_time is accepted"