From 698c5f879466189e8c543500820514cf1e1b9191 Mon Sep 17 00:00:00 2001 From: Aya Hassan Date: Wed, 28 Jan 2026 14:49:12 +0100 Subject: [PATCH] Fix additional failing tests --- tests/e2e/test_network_conditions.py | 2 +- tests/light_push/test_multiple_nodes.py | 4 +++- tests/light_push/test_running_nodes.py | 10 +++++----- 3 files changed, 9 insertions(+), 7 deletions(-) diff --git a/tests/e2e/test_network_conditions.py b/tests/e2e/test_network_conditions.py index 04a4e04bf..6ee69e3ce 100644 --- a/tests/e2e/test_network_conditions.py +++ b/tests/e2e/test_network_conditions.py @@ -322,7 +322,7 @@ class TestNetworkConditions(StepsRelay): self.tc.clear(self.node1) - @pytest.mark.xfail(reason="Fails under high packet loss percentage") + @pytest.mark.xfail(reason="Fails under high packet loss percentage 60") def test_relay_4_nodes_sender_packet_loss_50_15sec_timeout(self): self.node3 = WakuNode(NODE_2, f"node3_{self.test_id}") self.node4 = WakuNode(NODE_2, f"node4_{self.test_id}") diff --git a/tests/light_push/test_multiple_nodes.py b/tests/light_push/test_multiple_nodes.py index c06cb6ab8..c3bdf81a0 100644 --- a/tests/light_push/test_multiple_nodes.py +++ b/tests/light_push/test_multiple_nodes.py @@ -1,3 +1,4 @@ +import pytest from src.env_vars import NODE_1 from src.libs.common import delay from src.steps.light_push import StepsLightPush @@ -7,7 +8,7 @@ class TestMultipleNodes(StepsLightPush): def test_2_receiving_nodes__relay_node1_forwards_lightpushed_message_to_relay_node2(self): self.setup_first_receiving_node(lightpush="true", relay="true") self.setup_second_receiving_node(lightpush="false", relay="true") - self.setup_first_lightpush_node(lightpush="true", relay="false") + self.setup_first_lightpush_node(lightpush="true", relay="true") self.subscribe_to_pubsub_topics_via_relay() self.check_light_pushed_message_reaches_receiving_peer(sender=self.light_push_node1) @@ -22,6 +23,7 @@ class TestMultipleNodes(StepsLightPush): get_messages_response = self.receiving_node2.get_filter_messages(self.test_content_topic) assert len(get_messages_response) == 1, "Lightpushed message was not relayed to the filter node" + @pytest.mark.skip(reason=" test has m=no meaning now as relay = false won't work , moght be used in future if relay = false work again") def test_2_lightpush_nodes_and_2_receiving_nodes(self): self.setup_first_receiving_node(lightpush="true", relay="true") self.setup_second_receiving_node(lightpush="false", relay="true") diff --git a/tests/light_push/test_running_nodes.py b/tests/light_push/test_running_nodes.py index 540e83f9b..d0aba7d3f 100644 --- a/tests/light_push/test_running_nodes.py +++ b/tests/light_push/test_running_nodes.py @@ -14,19 +14,19 @@ class TestRunningNodes(StepsLightPush): except Exception as ex: assert "no waku relay found" in str(ex) or "failed to negotiate protocol: protocols not supported" in str(ex) - def test_main_node_only_lightpush__peer_only_filter(self): + def test_main_node_relay_lightpush__peer_only_filter(self): self.setup_first_receiving_node(lightpush="false", relay="false", filter="true") - self.setup_first_lightpush_node(lightpush="true", relay="false") + self.setup_first_lightpush_node(lightpush="true", relay="true") try: self.light_push_node1.send_light_push_message(self.create_payload()) raise AssertionError("Light push with non lightpush peer worked!!!") except Exception as ex: assert "Failed to request a message push: dial_failure" in str(ex) or "lightpush error" in str(ex) - def test_main_node_only_lightpush__peer_only_relay(self): + def test_main_node_relay_lightpush__peer_only_relay(self): self.setup_first_receiving_node(lightpush="false", relay="true") self.subscribe_to_pubsub_topics_via_relay() - self.setup_first_lightpush_node(lightpush="true", relay="false") + self.setup_first_lightpush_node(lightpush="true", relay="true") try: self.light_push_node1.send_light_push_message(self.create_payload()) raise AssertionError("Light push with non lightpush peer worked!!!") @@ -59,7 +59,7 @@ class TestRunningNodes(StepsLightPush): def test_lightpush_with_a_single_receiving_node(self): self.setup_first_receiving_node(lightpush="true", relay="true") - self.setup_first_lightpush_node(lightpush="true", relay="false") + self.setup_first_lightpush_node(lightpush="true", relay="true") self.subscribe_to_pubsub_topics_via_relay() try: self.check_light_pushed_message_reaches_receiving_peer(sender=self.light_push_node1)