self review

.github/workflows/test.yml

@@ -93,4 +93,4 @@ jobs:
         echo "- **Additonal Nodes**: ${{ env.ADDITIONAL_NODES}}" >> $GITHUB_STEP_SUMMARY
         echo "- **Protocol**: ${{ env.PROTOCOL }}" >> $GITHUB_STEP_SUMMARY
         echo "## Test Results" >> $GITHUB_STEP_SUMMARY
-        echo "Allure report will be available at: https://waku-org.github.io/waku-interop-tests/${{ github.run_number }}" >> $GITHUB_STEP_SUMMARY
+        echo "Allure report will be available at: https://waku-org.github.io/waku-interop-tests/${{ github.run_number }}" >> $GITHUB_STEP_SUMMARY

src/steps/relay.py

@@ -55,7 +55,7 @@ class StepsRelay:
     def relay_warm_up(self):
         try:
             self.wait_for_published_message_to_reach_peer()
-            logger.info("WARM UP successful for the main nodes!!")
+            logger.info("WARM UP successful!!")
         except Exception as ex:
             raise TimeoutError(f"WARM UP FAILED WITH: {ex}")
 
@@ -76,6 +76,7 @@ class StepsRelay:
             received_message = message_rpc_response_schema.load(get_messages_response[0])
             self.assert_received_message(message, received_message)
 
+    # we need much bigger timeout in CI because we run tests in parallel there and the machine itself is slower
     @allure.step
     def wait_for_published_message_to_reach_peer(
         self, timeout_duration=120 if RUNNING_IN_CI else 20, time_between_retries=1, sender=None, peer_list=None

tests/relay/test_multiple_nodes.py

@@ -1,10 +1,6 @@
-from time import sleep
 import pytest
-from src.libs.custom_logger import get_custom_logger
 from src.steps.relay import StepsRelay
 
-logger = get_custom_logger(__name__)
-
 
 @pytest.mark.usefixtures("setup_main_relay_nodes", "setup_optional_relay_nodes", "subscribe_main_relay_nodes")
 class TestMultipleNodes(StepsRelay):