From 1d71bc60c7d2098b0a8ad869ac83016fb036b66b Mon Sep 17 00:00:00 2001 From: aya Date: Sun, 8 Dec 2024 15:51:11 +0200 Subject: [PATCH] Fix review points on PR --- .github/workflows/nim_waku_PR.yml | 10 ++++------ .github/workflows/test_PR_image.yml | 2 +- 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/.github/workflows/nim_waku_PR.yml b/.github/workflows/nim_waku_PR.yml index 62dab74d..084b8479 100644 --- a/.github/workflows/nim_waku_PR.yml +++ b/.github/workflows/nim_waku_PR.yml @@ -1,12 +1,10 @@ -name: Nim -> Nim Waku Interop Tests +name: Nim -> Interop Tests PR concurrency: group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }} cancel-in-progress: false on: - schedule: - - cron: '0 5 * * *' workflow_dispatch: workflow_call: inputs: @@ -15,11 +13,11 @@ on: type: string jobs: - test-common: + test-pr: uses: ./.github/workflows/test_PR_image.yml secrets: inherit with: node1: ${{ inputs.node_nwaku }} - node2: "wakuorg/nwaku:latest" - additional_nodes: "wakuorg/nwaku:latest,wakuorg/nwaku:latest,wakuorg/nwaku:latest" + node2: ${{ inputs.node_nwaku }} + additional_nodes: ${{ inputs.node_nwaku }} caller: "nim" \ No newline at end of file diff --git a/.github/workflows/test_PR_image.yml b/.github/workflows/test_PR_image.yml index ba102571..66ff109a 100644 --- a/.github/workflows/test_PR_image.yml +++ b/.github/workflows/test_PR_image.yml @@ -1,5 +1,5 @@ -name: Interop Tests Common +name: Interop Tests PR on: workflow_call: