From 194477bd72f85c9bdc52e9b3c1433d67a218276d Mon Sep 17 00:00:00 2001 From: Aya Hassan Date: Sun, 7 Jun 2026 20:28:17 +0200 Subject: [PATCH] fix the .so build issue --- .github/workflows/test_common.yml | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/.github/workflows/test_common.yml b/.github/workflows/test_common.yml index 695b3e019..9c35b562a 100644 --- a/.github/workflows/test_common.yml +++ b/.github/workflows/test_common.yml @@ -117,6 +117,10 @@ jobs: echo "$HOME/.nimble/bin" >> "$GITHUB_PATH" export PATH="$HOME/.nimble/bin:$PATH" choosenim 2.2.4 + # Pin the nimble that generated logos-delivery's nimble.lock. A newer + # nimble recomputes the locked Nim package checksum differently, which + # makes `nimble setup --localdeps` abort with a checksum mismatch. + (cd /tmp && nimble install "nimble@0.22.3" -y) nim --version nimble --version @@ -137,13 +141,10 @@ jobs: ln -sf waku.nimble waku.nims - # install Nim deps - nimble install -y - - # do the real setup, do not fake .nimble-setup - make setup - - # now build the shared library + # `make liblogosdelivery` resolves the locked deps via + # `nimble setup --localdeps` (build-deps prerequisite); a bare + # `nimble install -y` here is redundant and pulls Nim from the lock, + # which is what triggered the checksum mismatch. make liblogosdelivery SO_PATH="$(find . -type f -name 'liblogosdelivery.so' | head -n 1)"