From 884f65ecdf5383da99d47378499246dd04fb2b56 Mon Sep 17 00:00:00 2001
From: Prem Chaitanya Prathi <chaitanyaprem@gmail.com>
Date: Fri, 4 Aug 2023 17:19:53 +0530
Subject: [PATCH] fix: noise protocol channel close race condition

---
 waku/v2/protocol/noise/pairing_relay_messenger.go | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/waku/v2/protocol/noise/pairing_relay_messenger.go b/waku/v2/protocol/noise/pairing_relay_messenger.go
index e5554d50..edb14192 100644
--- a/waku/v2/protocol/noise/pairing_relay_messenger.go
+++ b/waku/v2/protocol/noise/pairing_relay_messenger.go
@@ -95,6 +95,7 @@ func (r *NoiseWakuRelay) Subscribe(ctx context.Context, contentTopic string) <-c
 		for {
 			select {
 			case <-ctx.Done():
+				close(sub.msgChan)
 				return
 			case env := <-sub.broadcastSub.Ch:
 				if env == nil {
@@ -137,7 +138,6 @@ func (r *NoiseWakuRelay) Stop() {
 	for _, contentTopicSubscriptions := range r.subscriptionChPerContentTopic {
 		for _, c := range contentTopicSubscriptions {
 			c.broadcastSub.Unsubscribe()
-			close(c.msgChan)
 		}
 	}
 }