From 4e19d93da1e116d550e3e5009417d6dd3351c7dc Mon Sep 17 00:00:00 2001 From: Prem Chaitanya Prathi Date: Mon, 8 Jan 2024 21:18:56 +0530 Subject: [PATCH] chore: increase maxContentFilter limit for Filter protocol to 100 (#1000) --- waku/v2/protocol/filter/filter_subscribe_test.go | 5 +++-- waku/v2/protocol/filter/pb/validation.go | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/waku/v2/protocol/filter/filter_subscribe_test.go b/waku/v2/protocol/filter/filter_subscribe_test.go index 3420a324..b7579f8c 100644 --- a/waku/v2/protocol/filter/filter_subscribe_test.go +++ b/waku/v2/protocol/filter/filter_subscribe_test.go @@ -4,10 +4,11 @@ import ( "context" "crypto/rand" "encoding/hex" - "github.com/waku-org/go-waku/waku/v2/protocol/filter/pb" "sync" "time" + "github.com/waku-org/go-waku/waku/v2/protocol/filter/pb" + "github.com/libp2p/go-libp2p/core/peerstore" "github.com/waku-org/go-waku/tests" "github.com/waku-org/go-waku/waku/v2/protocol" @@ -195,7 +196,7 @@ func (s *FilterTestSuite) TestSubscriptionRefresh() { } func (s *FilterTestSuite) TestContentTopicsLimit() { - var maxContentTopics = 30 + var maxContentTopics = pb.MaxContentTopicsPerRequest // Create test context s.ctx, s.ctxCancel = context.WithTimeout(context.Background(), 20*time.Second) // Test can't exceed 10 seconds diff --git a/waku/v2/protocol/filter/pb/validation.go b/waku/v2/protocol/filter/pb/validation.go index 2e0d450d..d37e132e 100644 --- a/waku/v2/protocol/filter/pb/validation.go +++ b/waku/v2/protocol/filter/pb/validation.go @@ -7,7 +7,7 @@ import ( "golang.org/x/exp/slices" ) -const MaxContentTopicsPerRequest = 30 +const MaxContentTopicsPerRequest = 100 var ( errMissingRequestID = errors.New("missing RequestId field")