From 4c52149facd6e3b21ca606fde549cdefe44e7d9b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?rich=CE=9Brd?= Date: Wed, 30 Aug 2023 01:18:06 -0400 Subject: [PATCH] chore: log succesful message pushes (#694) Co-authored-by: Prem Chaitanya Prathi --- waku/v2/protocol/filter/server.go | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/waku/v2/protocol/filter/server.go b/waku/v2/protocol/filter/server.go index 60e5d10a..b47c8db3 100644 --- a/waku/v2/protocol/filter/server.go +++ b/waku/v2/protocol/filter/server.go @@ -267,7 +267,12 @@ func (wf *WakuFilterFullNode) filterListener(ctx context.Context) { } func (wf *WakuFilterFullNode) pushMessage(ctx context.Context, peerID peer.ID, env *protocol.Envelope) error { - logger := wf.log.With(logging.HostID("peer", peerID)) + logger := wf.log.With( + logging.HostID("peer", peerID), + logging.HexBytes("envelopeHash", env.Hash()), + zap.String("pubsubTopic", env.PubsubTopic()), + zap.String("contentTopic", env.Message().ContentTopic), + ) messagePush := &pb.MessagePushV2{ PubsubTopic: env.PubsubTopic(), @@ -298,12 +303,15 @@ func (wf *WakuFilterFullNode) pushMessage(ctx context.Context, peerID peer.ID, e } else { wf.metrics.RecordError(writeResponseFailure) } - logger.Error("pushing messages to peer", logging.HexBytes("envelopeHash", env.Hash()), zap.String("pubsubTopic", env.PubsubTopic()), zap.String("contentTopic", env.Message().ContentTopic), zap.Error(err)) + logger.Error("pushing messages to peer", zap.Error(err)) wf.subscriptions.FlagAsFailure(peerID) return nil } wf.subscriptions.FlagAsSuccess(peerID) + + logger.Info("message pushed succesfully") // TODO: remove or change to debug once dogfooding of filter is complete + return nil }