From 37658821034977b9ed0abbe5c824d7c41f7449ff Mon Sep 17 00:00:00 2001 From: Richard Ramos Date: Tue, 23 Nov 2021 10:17:01 -0400 Subject: [PATCH] fix: code review --- waku/v2/discv5/discover.go | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/waku/v2/discv5/discover.go b/waku/v2/discv5/discover.go index 54993f84..3db89479 100644 --- a/waku/v2/discv5/discover.go +++ b/waku/v2/discv5/discover.go @@ -196,12 +196,11 @@ func (d *DiscoveryV5) listen() error { d.udpAddr = conn.LocalAddr().(*net.UDPAddr) - if d.NAT != nil { - if !d.udpAddr.IP.IsLoopback() { - go func() { - nat.Map(d.NAT, d.quit, "udp", d.udpAddr.Port, d.udpAddr.Port, "go-waku discv5 discovery") - }() - } + if d.NAT != nil && !d.udpAddr.IP.IsLoopback() { + go func() { + nat.Map(d.NAT, d.quit, "udp", d.udpAddr.Port, d.udpAddr.Port, "go-waku discv5 discovery") + }() + } d.localnode.SetFallbackUDP(d.udpAddr.Port)