mirror of
https://github.com/logos-messaging/logos-messaging-go-bindings.git
synced 2026-07-04 18:00:03 +00:00
d5d5a215ed
logos-delivery#4012 unifies the node lifecycle on logosdelivery_* and ships the full API — Messaging, Reliable Channels, and the low-level Kernel (waku_*) tier — in one liblogosdelivery library, retiring the separate libwaku. Migrate the bindings onto it. - internal/ffi: collapse the two bridges into one internal/ffi/liblogosdelivery over the single library. The kernel wrappers keep calling waku_* (kernel header), the lifecycle now uses logosdelivery_create_node/start_node/ stop_node/destroy (waku_new/start/stop/destroy are gone), events use logosdelivery_set_event_callback. Include liblogosdelivery_kernel.h (which re-exports the stable header) and link -llogosdelivery. Remove internal/ffi/libwaku. - pkg/kernel: repoint at internal/ffi/liblogosdelivery; the Makefile links -llogosdelivery. - CI: build only `make liblogosdelivery`, headers from library/, single -llogosdelivery. Pinned to logos-delivery#4012 until it merges (see the TODO/LOGOS_DELIVERY_REF in pr.yml). The high-level MessagingClient (pkg/messaging) lands in a follow-up PR on top. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
99 lines
3.6 KiB
YAML
99 lines
3.6 KiB
YAML
name: PR
|
|
|
|
on:
|
|
pull_request:
|
|
branches:
|
|
- master
|
|
|
|
# Cancel superseded runs on the same PR.
|
|
concurrency:
|
|
group: pr-${{ github.ref }}
|
|
cancel-in-progress: true
|
|
|
|
jobs:
|
|
gate:
|
|
runs-on: ubuntu-latest
|
|
env:
|
|
# Clone the logos-delivery checkout OUTSIDE the module tree: a directory
|
|
# named `vendor/` at the module root would put Go into vendor mode.
|
|
LOGOS_DELIVERY_DIR: ${{ github.workspace }}/.logos-delivery
|
|
# TODO(revert once merged): pinned to logos-delivery#4012, which unifies
|
|
# the node lifecycle on logosdelivery_* and ships the full API in the
|
|
# single liblogosdelivery library. Point back at the default branch after
|
|
# it merges.
|
|
LOGOS_DELIVERY_REF: update-examples-ffi-node-lifecycle
|
|
# The single liblogosdelivery library exposes the full API; its headers
|
|
# live in library/. The bridge self-links -llogosdelivery via a #cgo
|
|
# directive, so no -l is set here.
|
|
CGO_CFLAGS: -I${{ github.workspace }}/.logos-delivery/library/
|
|
CGO_LDFLAGS: -L${{ github.workspace }}/.logos-delivery/build/ -Wl,-rpath,${{ github.workspace }}/.logos-delivery/build/
|
|
# Build in module mode; never use a vendor/ dir.
|
|
GOFLAGS: -mod=mod
|
|
|
|
steps:
|
|
- name: Check out repository
|
|
uses: actions/checkout@v4
|
|
with:
|
|
fetch-depth: 0
|
|
|
|
- name: Set up Go
|
|
uses: actions/setup-go@v5
|
|
with:
|
|
go-version: "1.24"
|
|
|
|
- name: Resolve logos-delivery commit
|
|
# Cache the built library keyed on the exact upstream commit, so the
|
|
# expensive clone + build is skipped while the pinned ref is unchanged.
|
|
id: logos-delivery-rev
|
|
run: |
|
|
rev=$(git ls-remote https://github.com/logos-messaging/logos-delivery.git "$LOGOS_DELIVERY_REF" | cut -f1)
|
|
echo "rev=$rev" >> "$GITHUB_OUTPUT"
|
|
|
|
- name: Cache logos-delivery build
|
|
id: logos-delivery-cache
|
|
uses: actions/cache@v4
|
|
with:
|
|
path: ${{ env.LOGOS_DELIVERY_DIR }}
|
|
key: logos-delivery-${{ runner.os }}-${{ steps.logos-delivery-rev.outputs.rev }}
|
|
|
|
- name: Clone logos-delivery
|
|
if: steps.logos-delivery-cache.outputs.cache-hit != 'true'
|
|
run: git clone --depth 1 --branch "$LOGOS_DELIVERY_REF" https://github.com/logos-messaging/logos-delivery.git "$LOGOS_DELIVERY_DIR"
|
|
|
|
- name: Build liblogosdelivery
|
|
if: steps.logos-delivery-cache.outputs.cache-hit != 'true'
|
|
run: make -C "$LOGOS_DELIVERY_DIR" liblogosdelivery -j
|
|
|
|
- name: go build
|
|
run: go build ./...
|
|
|
|
- name: go vet
|
|
run: go vet ./...
|
|
|
|
- name: go mod tidy is clean
|
|
# `go mod tidy` must be a no-op on a well-maintained module. If it
|
|
# changes go.mod/go.sum the PR left them out of sync — fail and show
|
|
# the diff so the author can commit the tidied result.
|
|
run: |
|
|
go mod tidy
|
|
git diff --exit-code go.mod go.sum
|
|
|
|
- name: Ensure base ref is available for lint
|
|
# golangci-lint's new-from-merge-base needs origin/master present.
|
|
run: git fetch --no-tags origin master
|
|
|
|
- name: golangci-lint
|
|
# v7 is required for golangci-lint v2.
|
|
uses: golangci/golangci-lint-action@v7
|
|
with:
|
|
version: v2.4.0
|
|
|
|
- name: go test messaging (run)
|
|
# Fast, network-free unit tests for the Messaging API + its ffi bridge.
|
|
run: go test ./pkg/messaging/... ./internal/ffi/...
|
|
|
|
- name: go test kernel (compile)
|
|
# The kernel suite is heavy integration (runs nightly in CI.yml), so
|
|
# only compile its test binaries here.
|
|
run: go test -run '^$' ./pkg/kernel/...
|