From 6feba5b0df4d2c4c43c82fa7c876e2b00221bbb0 Mon Sep 17 00:00:00 2001
From: gabrielmer <101006718+gabrielmer@users.noreply.github.com>
Date: Mon, 14 Jul 2025 13:03:06 +0200
Subject: [PATCH] fix: return value check, support numShardsInNetwork (#87)

---
 waku/common/config.go | 1 +
 waku/nwaku.go         | 8 ++++----
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/waku/common/config.go b/waku/common/config.go
index 10e8678..a40fb74 100644
--- a/waku/common/config.go
+++ b/waku/common/config.go
@@ -36,4 +36,5 @@ type WakuConfig struct {
 	DnsAddrsNameServers         []string         `json:"dnsAddrsNameServers,omitempty"`
 	Discv5EnrAutoUpdate         bool             `json:"discv5EnrAutoUpdate,omitempty"`
 	MaxConnections              int              `json:"maxConnections,omitempty"`
+	NumShardsInNetwork          uint16           `json:"numShardsInNetwork"`
 }
diff --git a/waku/nwaku.go b/waku/nwaku.go
index df90b2e..fbeb0f0 100644
--- a/waku/nwaku.go
+++ b/waku/nwaku.go
@@ -398,16 +398,16 @@ func NewWakuNode(config *common.WakuConfig, nodeName string) (*WakuNode, error)
 	defer C.free(unsafe.Pointer(cJsonConfig))
 	defer C.freeResp(resp)
 
+	wg.Add(1)
+	n.wakuCtx = C.cGoWakuNew(cJsonConfig, resp)
+	wg.Wait()
+
 	if C.getRet(resp) != C.RET_OK {
 		errMsg := C.GoStringN(C.getMyCharPtr(resp), C.int(C.getMyCharLen(resp)))
 		Error("error wakuNew for %s: %v", nodeName, errMsg)
 		return nil, errors.New(errMsg)
 	}
 
-	wg.Add(1)
-	n.wakuCtx = C.cGoWakuNew(cJsonConfig, resp)
-	wg.Wait()
-
 	n.MsgChan = make(chan common.Envelope, MsgChanBufferSize)
 	n.TopicHealthChan = make(chan topicHealth, TopicHealthChanBufferSize)
 	n.ConnectionChangeChan = make(chan connectionChange, ConnectionChangeChanBufferSize)