mirror of
https://github.com/logos-messaging/logos-delivery.git
synced 2026-07-22 04:29:42 +00:00
1ef53c9506
Channel traffic could not flow at all: the Encrypt/Decrypt brokers had no provider registered, so every segment failed with "no provider registered for input signature" and the send surfaced as "one or more segments failed". createReliableChannel documents that providers must be installed first, but library/ never installed any and exposed no way for a caller to, which made the channel API unusable through the FFI. The mechanism is named per channel rather than defaulted, so nothing silently gets pass-through "encryption" on a network built for private messaging -- the caller has to say "noop" and mean it. Only noop exists today; anything else is rejected rather than ignored. Caveat, noted in the code: the brokers dispatch to one provider process-wide, so the per-channel name installs a global provider and channels asking for different mechanisms would fight over it. Naming it at creation is still the right seam for when real providers land. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
83 lines
2.6 KiB
Nim
83 lines
2.6 KiB
Nim
import std/json
|
|
import chronos, results, ffi
|
|
import
|
|
logos_delivery/waku/common/base64,
|
|
logos_delivery,
|
|
logos_delivery/channels/encryption/noop_encryption,
|
|
logos_delivery/waku/waku_core/topics/content_topic,
|
|
logos_delivery/api/types,
|
|
../declare_lib
|
|
|
|
proc installEncryption(mechanism: string): Result[void, string] =
|
|
## The Encrypt/Decrypt brokers dispatch to a single provider, so this installs
|
|
## it process-wide even though the mechanism is named per channel: channels
|
|
## created with different mechanisms would fight over it, last one winning.
|
|
## Traffic cannot flow until some provider is registered.
|
|
case mechanism
|
|
of "noop":
|
|
setNoopEncryption()
|
|
ok()
|
|
else:
|
|
err("unknown encryption mechanism '" & mechanism & "'; supported: noop")
|
|
|
|
proc logosdeliveryChannelCreate*(
|
|
lib: LogosDelivery,
|
|
channelIdStr: string,
|
|
contentTopicStr: string,
|
|
senderIdStr: string,
|
|
encryptionStr: string,
|
|
): Future[Result[string, string]] {.ffi.} =
|
|
requireChannels(lib, "ChannelCreate"):
|
|
return err(errMsg)
|
|
|
|
installEncryption(encryptionStr).isOkOr:
|
|
return err("ChannelCreate failed: " & error)
|
|
|
|
let id = lib.reliableChannelManager.createReliableChannel(
|
|
ChannelId(channelIdStr),
|
|
ContentTopic(contentTopicStr),
|
|
SdsParticipantID(senderIdStr),
|
|
).valueOr:
|
|
return err("ChannelCreate failed: " & $error)
|
|
|
|
return ok(string(id))
|
|
|
|
proc logosdeliveryChannelSend*(
|
|
lib: LogosDelivery, channelIdStr: string, messageJson: string
|
|
): Future[Result[string, string]] {.ffi.} =
|
|
## `messageJson` carries `{ "payload": <base64>, "ephemeral": <bool> }`.
|
|
requireChannels(lib, "ChannelSend"):
|
|
return err(errMsg)
|
|
|
|
var jsonNode: JsonNode
|
|
try:
|
|
jsonNode = parseJson(messageJson)
|
|
except Exception as e:
|
|
return err("Failed to parse channel message JSON: " & e.msg)
|
|
|
|
if not jsonNode.hasKey("payload"):
|
|
return err("Missing payload field")
|
|
|
|
let payload = base64.decode(Base64String(jsonNode["payload"].getStr())).valueOr:
|
|
return err("invalid payload format: " & error)
|
|
|
|
let ephemeral = jsonNode.getOrDefault("ephemeral").getBool(false)
|
|
|
|
let requestId = (
|
|
await lib.reliableChannelManager.send(ChannelId(channelIdStr), payload, ephemeral)
|
|
).valueOr:
|
|
return err("ChannelSend failed: " & $error)
|
|
|
|
return ok($requestId)
|
|
|
|
proc logosdeliveryChannelClose*(
|
|
lib: LogosDelivery, channelIdStr: string
|
|
): Future[Result[string, string]] {.ffi.} =
|
|
requireChannels(lib, "ChannelClose"):
|
|
return err(errMsg)
|
|
|
|
(await lib.reliableChannelManager.closeChannel(ChannelId(channelIdStr))).isOkOr:
|
|
return err("ChannelClose failed: " & $error)
|
|
|
|
return ok("")
|