NagyZoltanPeter e8566db8ee
fix(persistency): own Persistency per node instead of a process-global singleton (#4109)
* fix(persistency): own Persistency per node instead of a process-global singleton

The Persistency singleton (gPersistency) was allocated on whichever FFI
thread first ran waku.start; under --mm:refc its memory belonged to that
thread's heap, so a second library context adopting it read a foreign
heap (SIGSEGV in sdsPersistence -> openJob -> tables.rawGet), one
context's stop stole the other's SDS persistence, and a destroyed
context poisoned re-init with a different local-storage-path.

- remove the singleton (instance/reset/gPersistency); Persistency.new is
  the public constructor, no lock needed (instances are thread-confined)
- own the instance as Waku.persistency: created and provided in
  waku.start, cleared and closed in waku.stop on the owning thread
- expose it via a sync GetPersistency RequestBroker scoped to the node's
  BrokerContext; sdsPersistence resolves through it (same-thread ref
  return, no marshalling)
- add InMemoryStoragePath (":memory:") support: private in-memory SQLite
  per job worker, for tests
- rewrite test_singleton as per-instance + broker coverage; rewrite
  test_thread_affinity from a known-failing UB repro into a regression
  guard (two in-memory jobs, worker spinup/teardown, cross-thread broker
  denial) and register it in test_all; migrate remaining tests to
  new/close; the FFI lifecycle test's stop-steals and different-paths
  cases now pass against the real dylib

The FFI destroy-without-stop teardown gap remains tracked in #4108.

Fixes #4103

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(persistency): create the instance only after startup fully succeeds

waku.start has many error return paths; creating Persistency early meant
every one of them left the field set and the GetPersistency provider
installed with no teardown. Persistency.new is inert (no threads or
files until the first openJob) and every consumer runs post-start, so
creating and providing it as the last startup step removes the need for
any error-path cleanup entirely.

Addresses PR #4109 review feedback.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(persistency): create early for startup-stage restores, tear down on failed start

Creating the instance as the last startup step made it impossible for
any stage of start to restore persisted data (e.g. a future store-state
restore). Restore the original ordering -- create and provide the
instance first -- and cover every error return path of waku.start with a
success-flag defer that clears the provider and closes the instance.
Teardown is factored into closePersistency, shared by stop and the
failed-start path.

Addresses PR #4109 review discussion.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* chore(persistency): address remaining Copilot review findings

- document that Persistency instances are thread-confined (not
  thread-safe) on the type itself, pointing at the GetPersistency broker
  as the sanctioned access path
- use tryRemoveFile for the FFI test's log cleanup so an unremovable
  file cannot fail the test for unrelated reasons

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* Fix comment

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-08-06 23:35:10 +02:00
2026-08-05 09:37:10 +02:00
2022-11-21 09:31:03 +01:00
2026-05-07 18:19:34 +02:00
2026-01-30 11:52:25 +00:00
2026-05-27 10:40:54 +02:00

Logos Messaging Nim

Introduction

This repository implements a set of libp2p protocols aimed to bring private communications.

  • Nim implementation of these specs.
  • C library that exposes the implemented protocols.
  • CLI application that allows you to run a logos-delivery node.
  • Examples.
  • Various tests of above.

For more details see the source code

How to Build & Run ( Linux, MacOS & WSL )

These instructions are generic. For more detailed instructions, see the source code above.

Recommended and tested toolchain versions (these are installed when you follow the build instructions below):

  • Nim 2.2.4
  • Nimble 0.22.3

Prerequisites

The standard developer tools, including a C compiler, GNU Make, Bash, and Git.

In some distributions (Fedora linux for example), you may need to install which utility separately. Nimbus build system is relying on it.

You'll also need an installation of Rust and its toolchain (specifically rustc and cargo). The easiest way to install these, is using rustup:

Rust:

curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh

Wakunode

# The first `make` invocation will initialize the local dependency state.
make wakunode2

# Build with custom compilation flags. Do not use NIM_PARAMS unless you know what you are doing.
# Replace with your own flags
make wakunode2 NIMFLAGS="-d:chronicles_colors:none -d:disableMarchNative"

# Run with DNS bootstrapping
./build/wakunode2 --dns-discovery --dns-discovery-url=DNS_BOOTSTRAP_NODE_URL

# Run with the QUIC transport enabled
./build/wakunode2 --quic-support=true

# See available command line options
./build/wakunode2 --help

To join the network, you need to know the address of at least one bootstrap node. Please refer to the Waku README for more information.

For more on how to run wakunode2, refer to:

Issues

WSL

If you encounter difficulties building the project on WSL, consider placing the project within WSL's filesystem, avoiding the /mnt/ directory.

How to Build & Run ( Windows )

Windows Build Instructions

1. Install Required Tools

  • Git Bash Terminal: Download and install from https://git-scm.com/download/win
  • MSYS2:
    a. Download installer from https://www.msys2.org
    b. Install at "C:" (default location). Remove/rename the msys folder in case of previous installation. c. Use the mingw64 terminal from msys64 directory for package installation.

2. Install Dependencies

Open MSYS2 mingw64 terminal and run the following one-by-one :

pacman -Syu --noconfirm  
pacman -S --noconfirm --needed mingw-w64-x86_64-toolchain  
pacman -S --noconfirm --needed base-devel make cmake upx  
pacman -S --noconfirm --needed mingw-w64-x86_64-rust  
pacman -S --noconfirm --needed mingw-w64-x86_64-postgresql  
pacman -S --noconfirm --needed mingw-w64-x86_64-gcc  
pacman -S --noconfirm --needed mingw-w64-x86_64-gcc-libs  
pacman -S --noconfirm --needed mingw-w64-x86_64-libwinpthread-git  
pacman -S --noconfirm --needed mingw-w64-x86_64-zlib  
pacman -S --noconfirm --needed mingw-w64-x86_64-openssl  
pacman -S --noconfirm --needed mingw-w64-x86_64-python

3. Build Wakunode

  • Open Git Bash as administrator
  • clone nwaku and cd nwaku
  • Execute: ./scripts/build_windows.sh

4. Troubleshooting

If wakunode2.exe isn't generated:

  • Missing Dependencies: Verify with:
    which make cmake gcc g++ rustc cargo python3 upx
    If missing, revisit Step 2 or ensure MSYS2 is at C:\
  • Installation Conflicts: Remove existing MinGW/MSYS2/Git Bash installations and perform fresh install

Developing

Nim Runtime

This repository is bundled with a Nim runtime that includes the necessary dependencies for the project.

Before you can utilize the runtime you'll need to build the project, as detailed in a previous section. This will generate a nimbledeps/pkgs2 directory containing various dependencies.

If everything went well, you should see your prompt suffixed with [SuccessX]. Now you can run nim commands as usual.

Test Suite

# Run all the Waku tests
make test

# Run a specific test file
make test <test_file_path>
# e.g. : make test tests/wakunode2/test_all.nim

# Run a specific test name from a specific test file
make test <test_file_path> <test_name>
# e.g. : make test tests/wakunode2/test_all.nim "node setup is successful with default configuration"

Building single test files

During development it is helpful to build and run a single test file. To support this make has a specific target:

targets:

  • build/<relative path to your test file.nim>
  • test/<relative path to your test file.nim>

Binary will be created as <path to your test file.nim>.bin under the build directory .

# Build and run your test file separately
make test/tests/common/test_enr_builder.nim

Testing against js-waku

Refer to logos-delivery-js repo for instructions.

Formatting

Nim files are expected to be formatted using the nph version present in vendor/nph.

You can easily format file with the make nph/<relative path to nim> file command. For example:

make nph/waku/waku_core.nim

A convenient git hook is provided to automatically format file at commit time. Run the following command to install it:

make install-nph

Examples

Examples can be found in the examples folder. This includes a fully featured chat example.

Tools

Different tools and their corresponding how-to guides can be found in the tools folder.

Bugs, Questions & Features

For an inquiry, or if you would like to propose new features, feel free to open a general issue.

For bug reports, please tag your issue with the bug label.

If you believe the reported issue requires critical attention, please use the critical label to assist with triaging.

To get help, or participate in the conversation, join the Logos Discord server.

Docs

Description
Logos Messaging protocols implemented in Nim
Readme
Languages
Nim 89.3%
Python 6.8%
Shell 1.7%
Nix 0.7%
Makefile 0.6%
Other 0.8%