From ff98d853138c3f07c8c5074aa7a9d5ab6cf316b8 Mon Sep 17 00:00:00 2001
From: Fabiana Cecin <fabiana@waku.org>
Date: Thu, 23 Apr 2026 16:02:34 -0300
Subject: [PATCH] fix: relay validator registration and sync filter (#3823)

* reuse stored validator in relay
* fix skip check in store sync
* increase sync tolerance in test (matches similar test)
---
 tests/waku_store_sync/test_protocol.nim | 2 +-
 waku/waku_relay/protocol.nim            | 2 +-
 waku/waku_store_sync/reconciliation.nim | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/tests/waku_store_sync/test_protocol.nim b/tests/waku_store_sync/test_protocol.nim
index d1f5a102a..3ffa7ad4a 100644
--- a/tests/waku_store_sync/test_protocol.nim
+++ b/tests/waku_store_sync/test_protocol.nim
@@ -372,7 +372,7 @@ suite "Waku Sync: reconciliation":
     const
       msgCount = 400_000
       diffCount = 100_000
-      tol = 1000
+      tol = 10_000
 
     var diffMsgHashes: HashSet[WakuMessageHash]
     var missingIdx: HashSet[int]
diff --git a/waku/waku_relay/protocol.nim b/waku/waku_relay/protocol.nim
index b19173d36..e7b2c99cb 100644
--- a/waku/waku_relay/protocol.nim
+++ b/waku/waku_relay/protocol.nim
@@ -618,7 +618,7 @@ proc subscribe*(w: WakuRelay, pubsubTopic: PubsubTopic, handler: WakuRelayHandle
   # Otherwise this might lead to unintended behaviour.
   if not w.topicValidator.hasKey(pubSubTopic):
     let newValidator = w.generateOrderedValidator()
-    procCall GossipSub(w).addValidator(pubSubTopic, w.generateOrderedValidator())
+    procCall GossipSub(w).addValidator(pubSubTopic, newValidator)
     w.topicValidator[pubSubTopic] = newValidator
 
   # set this topic parameters for scoring
diff --git a/waku/waku_store_sync/reconciliation.nim b/waku/waku_store_sync/reconciliation.nim
index 9dd308255..b18251fff 100644
--- a/waku/waku_store_sync/reconciliation.nim
+++ b/waku/waku_store_sync/reconciliation.nim
@@ -145,7 +145,7 @@ proc preProcessPayload(
   # convert to skip range before processing
   for i in 0 ..< payload.ranges.len:
     let rangeType = payload.ranges[i][1]
-    if rangeType != RangeType.Skip:
+    if rangeType == RangeType.Skip:
       continue
 
     let upperBound = payload.ranges[i][0].b.time