From f1f02302f084c5c5e0ceded1796f69b6d154e58c Mon Sep 17 00:00:00 2001 From: Ivan FB Date: Fri, 29 May 2026 15:17:04 +0200 Subject: [PATCH] remove proc getChannelForTest proc --- channels/reliable_channel_manager.nim | 9 --------- .../channels/test_reliable_channel_send_receive.nim | 12 +++--------- 2 files changed, 3 insertions(+), 18 deletions(-) diff --git a/channels/reliable_channel_manager.nim b/channels/reliable_channel_manager.nim index c3ef2dcd7..79f59ac3f 100644 --- a/channels/reliable_channel_manager.nim +++ b/channels/reliable_channel_manager.nim @@ -61,15 +61,6 @@ proc stop*(self: ReliableChannelManager) {.async.} = if not self.waku.isNil(): await self.waku.deliveryService.stopDeliveryService() -proc getChannelForTest*( - self: ReliableChannelManager, channelId: ChannelId -): ReliableChannel = - ## Test-only: returns the channel for `channelId`, or `nil` if none - ## exists. Production callers must address channels by `channelId` - ## through the manager's `send` / `closeChannel` API — direct - ## references bypass the manager's lifecycle and pipeline. - self.channels.getOrDefault(channelId) - proc createReliableChannel*( self: ReliableChannelManager, channelId: ChannelId, diff --git a/tests/channels/test_reliable_channel_send_receive.nim b/tests/channels/test_reliable_channel_send_receive.nim index 1b10f2b2b..91e3a9685 100644 --- a/tests/channels/test_reliable_channel_send_receive.nim +++ b/tests/channels/test_reliable_channel_send_receive.nim @@ -187,9 +187,6 @@ suite "Reliable Channel - send state machine": ) .expect("createReliableChannel") - let chn = manager.getChannelForTest(channelId) - doAssert not chn.isNil() - let sentFut = newFuture[RequestId]("channel-sent") discard ChannelMessageSentEvent .listen( @@ -201,7 +198,7 @@ suite "Reliable Channel - send state machine": ) .expect("listen ChannelMessageSentEvent") - let channelReqId = chn.send("hello".toBytes()).expect("send") + let channelReqId = manager.send(channelId, "hello".toBytes()).expect("send") let dispatchDeadline = Moment.now() + 1.seconds while Moment.now() < dispatchDeadline and sendCalls == 0: @@ -258,9 +255,6 @@ suite "Reliable Channel - send state machine": ) .expect("createReliableChannel") - let chn = manager.getChannelForTest(channelId) - doAssert not chn.isNil() - let sentFut = newFuture[RequestId]("channel-sent") let erroredFut = newFuture[RequestId]("channel-errored") discard ChannelMessageSentEvent @@ -282,8 +276,8 @@ suite "Reliable Channel - send state machine": ) .expect("listen ChannelMessageErrorEvent") - let channelReqId1 = chn.send("first".toBytes()).expect("send 1") - let channelReqId2 = chn.send("second".toBytes()).expect("send 2") + let channelReqId1 = manager.send(channelId, "first".toBytes()).expect("send 1") + let channelReqId2 = manager.send(channelId, "second".toBytes()).expect("send 2") let dispatchDeadline = Moment.now() + 1.seconds while Moment.now() < dispatchDeadline and msgReqIds.len < 2: