From ef651a7cccadf862deb2788f1d726f2decb6bdf0 Mon Sep 17 00:00:00 2001 From: Igor Sirotin Date: Tue, 11 Aug 2026 13:05:25 +0200 Subject: [PATCH] fix(networks): move logos.dev preset to cluster-id 3 (#4113) * fix(networks): move logos.dev preset to cluster-id 3 The Logos Dev Network is now deployed on cluster 3. Update the `logos.dev` preset accordingly, along with the CLI help text and the library README preset table. The deprecated "cluster-id implies preset" shim now triggers on `--cluster-id=3` instead of `2`: cluster 2 is still the Logos Test Network, so keeping the old mapping would silently move a node that explicitly asked for cluster 2 onto cluster 3. Co-Authored-By: Claude Opus 5 (1M context) * fix(conf): keep the legacy cluster-id preset shim on cluster 2 Remapping the deprecated `--cluster-id` -> preset shim onto cluster 3 hijacked every caller that uses 3 as a plain cluster id with no preset, applying the whole logos.dev preset (p2p reliability, mix, discv5, dev entry nodes) on top. tests/api/test_api_send.nim does exactly that, and the extra reliability layer made Send emit `Sent` events the tests never asked for. Revert that hunk; only the preset's own cluster id moves to 3. Co-Authored-By: Claude Opus 5 (1M context) --------- Co-authored-by: Claude Opus 5 (1M context) --- library/README.md | 2 +- logos_delivery/waku/factory/networks_config.nim | 4 ++-- tests/api/test_node_conf.nim | 2 +- tools/confutils/cli_args.nim | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/library/README.md b/library/README.md index 82e1a77c8..ec08581eb 100644 --- a/library/README.md +++ b/library/README.md @@ -96,7 +96,7 @@ Available presets: | Preset | Cluster ID | RLN | Sharding | Network | | --- | --- | --- | --- | --- | | `twn` | 1 | on | auto (8 shards) | The Waku Network | -| `logos.dev` | 2 | off | auto (8 shards) | Logos Dev Network | +| `logos.dev` | 3 | off | auto (8 shards) | Logos Dev Network | | `logos.test` | 2 | off | auto (8 shards) | Logos Test Network | | `status.prod` | 16 | off | auto (1 shard) | Status Production Network | diff --git a/logos_delivery/waku/factory/networks_config.nim b/logos_delivery/waku/factory/networks_config.nim index 339922c02..80342b812 100644 --- a/logos_delivery/waku/factory/networks_config.nim +++ b/logos_delivery/waku/factory/networks_config.nim @@ -65,13 +65,13 @@ proc TheWakuNetworkConf*(T: type NetworkPresetConf): NetworkPresetConf = ], ) -# cluster-id=2 (Logos Dev Network) +# cluster-id=3 (Logos Dev Network) # Cluster configuration for the Logos Dev Network. proc LogosDevConf*(T: type NetworkPresetConf): NetworkPresetConf = const ZeroChainId = 0'u256 return NetworkPresetConf( maxMessageSize: DefaultMaxWakuMessageSizeStr, - clusterId: 2, + clusterId: 3, rlnRelay: false, rlnRelayEthContractAddress: "", rlnRelayDynamic: false, diff --git a/tests/api/test_node_conf.nim b/tests/api/test_node_conf.nim index cf2b36cc5..db64e9729 100644 --- a/tests/api/test_node_conf.nim +++ b/tests/api/test_node_conf.nim @@ -37,7 +37,7 @@ suite "WakuNodeConf - preset integration": let wakuConf = wakuConfRes.get() require wakuConf.validate().isOk() check: - wakuConf.clusterId == 2 + wakuConf.clusterId == 3 test "LogosTest preset applies LogosTestConf": ## Given diff --git a/tools/confutils/cli_args.nim b/tools/confutils/cli_args.nim index 1cb6292d2..6feaa5689 100644 --- a/tools/confutils/cli_args.nim +++ b/tools/confutils/cli_args.nim @@ -164,7 +164,7 @@ type WakuNodeConf* = object ## General node config preset* {. desc: - "Network preset to use. 'twn' is The RLN-protected Waku Network (cluster 1). 'logos.dev' is the Logos Dev Network (cluster 2). 'logos.test' is the Logos Test Network (cluster 2). 'status.prod' is the Status Production Network (cluster 16, RLN off, auto-sharding with 1 shard). Overrides other values.", + "Network preset to use. 'twn' is The RLN-protected Waku Network (cluster 1). 'logos.dev' is the Logos Dev Network (cluster 3). 'logos.test' is the Logos Test Network (cluster 2). 'status.prod' is the Status Production Network (cluster 16, RLN off, auto-sharding with 1 shard). Overrides other values.", defaultValue: "", name: "preset" .}: string