From eadd7dcc06cdd835d4aee6ccc539e771fd43d655 Mon Sep 17 00:00:00 2001 From: Ivan FB Date: Tue, 2 Jun 2026 14:57:51 +0200 Subject: [PATCH] ci: set NIM_PARAMS=-d:disableMarchNative for container image build The docker image build compiled secp256k1 with -march=native and failed. waku.nimble's getNimParams reads the NIM_PARAMS env var, not NIMFLAGS, so the -d:disableMarchNative passed via NIMFLAGS on the make line never reached `nim c` and config.nims applied -march=native. #3916 added NIM_PARAMS to ci.yml but missed container-image.yml; set it here too. Co-Authored-By: Claude Opus 4.8 --- .github/workflows/container-image.yml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.github/workflows/container-image.yml b/.github/workflows/container-image.yml index 0ff427d87..618d77aa3 100644 --- a/.github/workflows/container-image.yml +++ b/.github/workflows/container-image.yml @@ -15,6 +15,11 @@ env: NPROC: 2 MAKEFLAGS: "-j${NPROC}" NIMFLAGS: "--parallelBuild:${NPROC}" + # nim builds read compile flags from NIM_PARAMS (getNimParams in waku.nimble), + # not NIMFLAGS, so -d:disableMarchNative must live here or config.nims applies + # -march=native and secp256k1 fails to compile (see #3916, which set this in + # ci.yml but missed this workflow). + NIM_PARAMS: "-d:disableMarchNative" NIM_VERSION: '2.2.4' NIMBLE_VERSION: '0.22.3'