force FINALIZE partition detach after detecting shorter error (#3728)

This commit is contained in:
Ivan FB 2026-02-17 00:18:46 +01:00 committed by GitHub
parent 8f29070dcf
commit b38b5aaea1
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

View File

@ -1347,8 +1347,10 @@ proc removePartition(
(await self.performWriteQuery(detachPartitionQuery)).isOkOr:
info "detected error when trying to detach partition", error
if ($error).contains("FINALIZE") or
($error).contains("already pending detach in part"):
if ($error).contains("FINALIZE") or ($error).contains("already pending"):
## We assume "already pending detach in partitioned table ..." as possible error
debug "enforce detach with FINALIZE because of detected error", error
## We assume the database is suggesting to use FINALIZE when detaching a partition
let detachPartitionFinalizeQuery =
"ALTER TABLE messages DETACH PARTITION " & partitionName & " FINALIZE;"