From 5d7dde9444d33e0d4acc1d12f43947b12979338b Mon Sep 17 00:00:00 2001 From: Ivan FB Date: Fri, 29 May 2026 08:17:41 +0200 Subject: [PATCH] ci: cover build job and daily workflow with -d:disableMarchNative Per review on #3916: the previous commit only patched the test job's "Run tests" step. The build job (make V=1 all) and the ci-daily.yml workflow run on the same heterogeneous runner pool and compile secp256k1 the same way, so they hit the same asm register-pressure failure intermittently. Lift NIM_PARAMS to the workflow-level env: block in ci.yml so both jobs inherit it, and drop the now-redundant per-step export. Mirror the change in ci-daily.yml. Co-Authored-By: Claude Opus 4.7 --- .github/workflows/ci-daily.yml | 3 ++- .github/workflows/ci.yml | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci-daily.yml b/.github/workflows/ci-daily.yml index 009e6c523..dea30ab7e 100644 --- a/.github/workflows/ci-daily.yml +++ b/.github/workflows/ci-daily.yml @@ -8,7 +8,8 @@ on: env: NPROC: 2 MAKEFLAGS: "-j${NPROC}" - NIMFLAGS: "--parallelBuild:${NPROC} --colors:off -d:chronicles_colors:none" + NIMFLAGS: "--parallelBuild:${NPROC} --colors:off -d:chronicles_colors:none -d:disableMarchNative" + NIM_PARAMS: "-d:disableMarchNative" jobs: build: diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 4950d06bc..99e05947b 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -14,6 +14,7 @@ env: NPROC: 2 MAKEFLAGS: "-j${NPROC}" NIMFLAGS: "--parallelBuild:${NPROC} --colors:off -d:chronicles_colors:none -d:disableMarchNative" + NIM_PARAMS: "-d:disableMarchNative" NIM_VERSION: '2.2.4' NIMBLE_VERSION: '0.22.3' @@ -158,7 +159,6 @@ jobs: export MAKEFLAGS="-j1" export NIMFLAGS="--colors:off -d:chronicles_colors:none -d:disableMarchNative" - export NIM_PARAMS="-d:disableMarchNative" export USE_LIBBACKTRACE=0 make V=1 POSTGRES=$postgres_enabled test