logos-messaging/logos-delivery
1
0
Fork 0
mirror of https://github.com/logos-messaging/logos-delivery.git synced 2026-07-23 05:00:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

Gate lightpush Merkle refresh on RlnValidatorErrorMsg for 420 responses

Browse Source 
420 INVALID_MESSAGE is returned for any validateMessage failure, not just
RLN ones (e.g. oversized messages), so a bare status-code check triggers
an unbounded on-chain fetchMerkleProofElements RPC per rejected message.
Match the legacy-lightpush path: require the error description to contain
RlnValidatorErrorMsg before refreshing; 504 OUT_OF_RLN_PROOF remains
unconditional as it is unambiguously RLN-specific.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
stubbsta 2026-07-07 09:00:51 +02:00
parent f02cb1f881
commit 3f5c2697ec
No known key found for this signature in database
1 changed files with 13 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
logos_delivery/waku/node/waku_node/lightpush.nim
View File

@ -329,12 +329,19 @@ proc lightpushPublish*(
let firstResult =
await lightpushPublishHandler(node, pubsubForPublish, msgWithProof, toPeer, mixify)
# A publish error with status 420 (INVALID_MESSAGE) or 504 (OUT_OF_RLN_PROOF)
# can indicate a stale merkle proof path; refresh it and retry the publish
# once.
if firstResult.isOk() or rln.isNone() or
firstResult.error.code notin
[LightPushErrorCode.INVALID_MESSAGE, LightPushErrorCode.OUT_OF_RLN_PROOF]:
# A publish error can indicate a stale Merkle proof path; refresh it and
# retry the publish once. Gate only on unambiguously RLN-related failures:
# 504 (OUT_OF_RLN_PROOF) is always RLN-specific; 420 (INVALID_MESSAGE) is
# also returned for non-RLN rejections (e.g. oversized messages), so require
# the error description to contain RlnValidatorErrorMsg — matching the legacy
# lightpush path — to avoid unbounded on-chain RPCs on non-RLN errors.
let isRlnRelatedFailure =
firstResult.error.code == LightPushErrorCode.OUT_OF_RLN_PROOF or
(
firstResult.error.code == LightPushErrorCode.INVALID_MESSAGE and
firstResult.error.desc.get("").contains(RlnValidatorErrorMsg)
)
if firstResult.isOk() or rln.isNone() or not isRlnRelatedFailure:
return firstResult
info "lightpush send rejected; refreshing merkle proof and retrying once",