refactor: remove client-ffi and legacy nim bindings (#133)

closes: #77

The C consumer story lives downstream now: logos-chat-module wraps the
client crate and exposes its own C API. The in-tree client-ffi crate has
no consumers left, and the nim bindings still target the removed
Context-based C API.

- delete crates/client-ffi (including the message-exchange C example)
  and nim-bindings
- drop core/conversations' unused safer-ffi dependency plus the leftover
  C artifact crate-types: staticlib on core/conversations, cdylib on
  double-ratchets (neither crate has extern "C" exports)
- flake.nix: drop the default package (it built libclient_ffi.a plus its
  header); keep the logos-delivery package and the dev shell
- ci.yml: drop the C FFI smoketest steps (valgrind included), the rustup
  install the smoketest no longer needs, and the nix-build job that
  built the removed default package
- ADR 0001: point the FFI-compatibility driver at the downstream C API
  boundary instead of crates/client-ffi
This commit is contained in:
osmaczko
2026-06-15 17:55:58 +02:00
committed by GitHub
parent 78d6b6c47a
commit 9d9a691fe3
18 changed files with 45 additions and 1358 deletions
-35
View File
@@ -50,7 +50,6 @@ jobs:
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v4
- run: rustup update stable && rustup default stable
- uses: cachix/install-nix-action@v31
with:
nix_version: 2.34.6
@@ -60,19 +59,6 @@ jobs:
with:
primary-key: nix-${{ runner.os }}-fixtest-${{ hashFiles('flake.nix', 'flake.lock') }}
restore-prefixes-first-match: nix-${{ runner.os }}-
- name: Install valgrind
if: runner.os == 'Linux'
run: sudo apt-get install -y valgrind
- name: Build C FFI example
run: make
working-directory: crates/client-ffi/examples/message-exchange
- name: Run C FFI smoketest
run: ./c-client
working-directory: crates/client-ffi/examples/message-exchange
- name: Run C FFI smoketest under valgrind
if: runner.os == 'Linux'
run: make valgrind
working-directory: crates/client-ffi/examples/message-exchange
- name: Build logos-delivery
# Build through a patched nixpkgs (kaichaosun/nixpkgs fix-gitfetch),
# whose nix-prefetch-git disables git background auto-maintenance so the
@@ -92,24 +78,3 @@ jobs:
run: nix develop -c bash -c 'LOGOS_DELIVERY_LIB_DIR=./result/lib cargo build --release -p chat-cli'
- name: Run chat-cli smoketest
run: nix develop -c ./target/release/chat-cli --name ci-test --smoketest
nix-build:
name: Nix Build
strategy:
matrix:
os: [ubuntu-latest, macos-latest]
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v4
- uses: cachix/install-nix-action@v31
with:
nix_version: 2.34.6
extra_nix_config: |
experimental-features = nix-command flakes
- uses: nix-community/cache-nix-action@v6
with:
primary-key: nix-${{ runner.os }}-fixtest-${{ hashFiles('flake.nix', 'flake.lock') }}
restore-prefixes-first-match: nix-${{ runner.os }}-
# Same patched-nixpkgs override; the default package pulls in
# logos-delivery-lib, so it exercises the same nim-zlib fetch.
- run: nix build --override-input nixpkgs github:kaichaosun/nixpkgs/fix-gitfetch --print-build-logs