From 710c0bab1b3854c246549bb148067255364c71c5 Mon Sep 17 00:00:00 2001 From: Jazz Turner-Baggs <473256+jazzz@users.noreply.github.com> Date: Wed, 29 Apr 2026 23:02:19 -0700 Subject: [PATCH] Review fixes --- core/conversations/src/conversation/group_v1.rs | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/core/conversations/src/conversation/group_v1.rs b/core/conversations/src/conversation/group_v1.rs index fd15304..b7d8c87 100644 --- a/core/conversations/src/conversation/group_v1.rs +++ b/core/conversations/src/conversation/group_v1.rs @@ -343,11 +343,11 @@ where DS: DeliveryService, KP: KeyPackageProvider, { + // add_members returns: + // commit — the Commit message Alice broadcasts to all members + // welcome — the Welcome message sent privately to each new joiner + // _group_info — used for external joins; ignore for now fn add_member(&mut self, members: &[&AccountId]) -> Result<(), ChatError> { - // add_members returns: - // commit — the Commit message Alice broadcasts to all members - // welcome — the Welcome message sent privately to each new joiner - // _group_info — used for external joins; ignore for now let ctx_ref = self.ctx.borrow(); let provider = ctx_ref.provider(); @@ -362,7 +362,6 @@ where // The account_id is kept so invites can be addressed properly let keypkgs = members .iter() - // .map(|ident| self.key_package_for_account(ctx, ident)) .map(|ident| self.key_package_for_account(ident)) .collect::, ChatError>>()?;