From 4675e121ae3ea0fe6faa5897e5a14b1b12167a7c Mon Sep 17 00:00:00 2001
From: Jazz Turner-Baggs <473256+jazzz@users.noreply.github.com>
Date: Tue, 28 Apr 2026 15:05:57 -0700
Subject: [PATCH] Add comments to GroupV1Convo

---
 core/conversations/src/conversation/group_v1.rs | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/core/conversations/src/conversation/group_v1.rs b/core/conversations/src/conversation/group_v1.rs
index e3e1fbd..919c202 100644
--- a/core/conversations/src/conversation/group_v1.rs
+++ b/core/conversations/src/conversation/group_v1.rs
@@ -1,3 +1,7 @@
+/// GroupV1 is a conversationType which provides effecient handling of multiple participants
+/// Properties:
+///     - Harvest Now Decrypt Later (HNDL) protection provided by XWING
+///     - Multiple
 use std::cell::RefCell;
 use std::rc::Rc;
 
@@ -74,6 +78,7 @@ where
     DS: DeliveryService,
     KP: KeyPackageProvider,
 {
+    // Create a new conversation with the creator as the only participant.
     pub fn new(
         ctx: Rc<RefCell<MlsCtx>>,
         ds: Rc<RefCell<DS>>,
@@ -109,6 +114,7 @@ where
         })
     }
 
+    // Constructs a new conversation upon receiving a MlsWelcome message.
     pub fn new_from_welcome(
         ctx: Rc<RefCell<MlsCtx>>,
         ds: Rc<RefCell<DS>>,
@@ -171,6 +177,7 @@ where
         })
     }
 
+    // Configure the delivery service to listen for the required delivery addresses.
     fn subscribe(ds: &mut DS, convo_id: &str) -> Result<(), ChatError> {
         ds.subscribe(&Self::delivery_address_from_id(convo_id))
             .map_err(ChatError::generic)?;
@@ -307,7 +314,7 @@ where
         let provider = ctx_borrow.provider();
 
         if protocol_message.epoch() < self.mls_group.epoch() {
-            // TODO: (!) Determine how to handle messages for old epochs. Minimally log this.
+            // TODO: (P1) Add logging for messages arriving from past epoch.
             return Ok(None);
         }