From eecdb6aeeb886c67723602e096b4e912d07ab219 Mon Sep 17 00:00:00 2001 From: Danish Arora <35004822+danisharora099@users.noreply.github.com> Date: Mon, 12 Dec 2022 10:52:17 +0530 Subject: [PATCH] chore: upgrade to node 18 (#1061) * chore: change `localhost` -> `127.0.0.1` There is a change in how Node does DNS resolution in Node 18 vs 16 -- `localhost` resolves to `::1`, which is the equivalent of `127.0.0.1` but in IPv6 instead of IPv4. The server however is only listening on IPv4. Reference: https://github.com/nodejs/node/issues/40702#issuecomment-958143154 * refactor: change node version on CI from 16 to 18 --- .github/workflows/ci.yml | 2 +- packages/tests/src/nwaku.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 64aa99d1b4..c2ef53c76a 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -10,7 +10,7 @@ on: env: NWAKU_VERSION: "v0.13.0" - NODE_JS: "16" + NODE_JS: "18" jobs: check: diff --git a/packages/tests/src/nwaku.ts b/packages/tests/src/nwaku.ts index c5faecfbc7..a819407469 100644 --- a/packages/tests/src/nwaku.ts +++ b/packages/tests/src/nwaku.ts @@ -395,7 +395,7 @@ export class Nwaku { } get rpcUrl(): string { - return `http://localhost:${this.rpcPort}/`; + return `http://127.0.0.1:${this.rpcPort}/`; } private async rpcCall(