logos-messaging/js-waku
1
0
Fork 0
mirror of https://github.com/logos-messaging/js-waku.git synced 2026-01-02 13:53:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: prevent setting shard info from PX if it exists (#2561)

Browse Source 
* prevent setting px shard info

* address review
This commit is contained in:
Sasha 2025-08-15 00:30:07 +02:00 committed by GitHub
parent eab8ce81b4
commit dfb2baf004
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 23 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
packages/discovery/src/peer-exchange/peer_exchange_discovery.ts
View File

@ -207,6 +207,12 @@ export class PeerExchangeDiscovery
continue;
}
const hasPrevShardInfo = await this.hasShardInfo(peerInfo.id);
const metadata =
!hasPrevShardInfo && shardInfo
? { metadata: { shardInfo: encodeRelayShard(shardInfo) } }
: undefined;
// merge is smart enough to overwrite only changed parts
await this.components.peerStore.merge(peerInfo.id, {
tags: {
@ -214,11 +220,7 @@ export class PeerExchangeDiscovery
value: DEFAULT_PEER_EXCHANGE_TAG_VALUE
}
},
...(shardInfo && {
metadata: {
shardInfo: encodeRelayShard(shardInfo)
}
}),
...metadata,
...(peerInfo.multiaddrs && {
multiaddrs: peerInfo.multiaddrs
})
@ -236,6 +238,22 @@ export class PeerExchangeDiscovery
);
}
}
private async hasShardInfo(peerId: PeerId): Promise<boolean> {
try {
const peer = await this.components.peerStore.get(peerId);
if (!peer) {
return false;
}
return peer.metadata.has("shardInfo");
} catch (err) {
log.warn(`Error getting shard info for ${peerId.toString()}`, err);
}
return false;
}
}
export function wakuPeerExchangeDiscovery(