From b0d658c4a1e99d9a0a2da29babd87a16a2eea378 Mon Sep 17 00:00:00 2001 From: fbarbu15 Date: Mon, 9 Oct 2023 14:52:40 +0300 Subject: [PATCH] add comments for known issues --- packages/tests/tests/store/cursor.node.spec.ts | 3 ++- packages/tests/tests/store/page_size.node.spec.ts | 1 + packages/tests/tests/store/time_filter.node.spec.ts | 2 +- 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/packages/tests/tests/store/cursor.node.spec.ts b/packages/tests/tests/store/cursor.node.spec.ts index b8cd09d34b..39bd940f8e 100644 --- a/packages/tests/tests/store/cursor.node.spec.ts +++ b/packages/tests/tests/store/cursor.node.spec.ts @@ -153,6 +153,7 @@ describe("Waku Store, cursor", function () { } } } + // Should return same as go-waku. Raised bug: https://github.com/waku-org/nwaku/issues/2117 expect(messagesAfterCursor.length).to.eql(0); } catch (error) { if ( @@ -168,7 +169,7 @@ describe("Waku Store, cursor", function () { } }); - // PubsubTopic is ignored in the cursor. Needs fixing so it throws an error if it doesn't match with Decoder + // PubsubTopic is ignored in the cursor: https://github.com/waku-org/js-waku/pull/1640 it.skip("Passing cursor with wrong pubSubTopic", async function () { await sendMessages(nwaku, totalMsgs, TestContentTopic, DefaultPubSubTopic); waku = await startAndConnectLightNode(nwaku); diff --git a/packages/tests/tests/store/page_size.node.spec.ts b/packages/tests/tests/store/page_size.node.spec.ts index 2e2a552b07..cad9496412 100644 --- a/packages/tests/tests/store/page_size.node.spec.ts +++ b/packages/tests/tests/store/page_size.node.spec.ts @@ -80,6 +80,7 @@ describe("Waku Store, page size", function () { }); }); + // Possible issue here because pageSize differs across implementations it("Default pageSize", async function () { await sendMessages(nwaku, 20, TestContentTopic, DefaultPubSubTopic); waku = await startAndConnectLightNode(nwaku); diff --git a/packages/tests/tests/store/time_filter.node.spec.ts b/packages/tests/tests/store/time_filter.node.spec.ts index 8214454672..a56cb54e28 100644 --- a/packages/tests/tests/store/time_filter.node.spec.ts +++ b/packages/tests/tests/store/time_filter.node.spec.ts @@ -31,7 +31,7 @@ describe("Waku Store, time filter", function () { [-19000, -10, 10], [-19000, 1, 4], [-19000, -2, -1], - // [-19000, 0, 1000], // skipped because it fails on gowaku + // [-19000, 0, 1000], // skipped for now because it fails on gowaku which returns messages > startTime [-19000, -1000, 0], [19000, -10, 10], // message in the future [-19000, 10, -10] // startTime is newer than endTime