From 91276371516020a90b07dcbf8cf841b2f2c1645f Mon Sep 17 00:00:00 2001
From: Danish Arora <danisharora099@gmail.com>
Date: Wed, 22 Jan 2025 18:01:04 +0530
Subject: [PATCH] fix: return early if expect passes

---
 packages/tests/src/lib/index.ts | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/packages/tests/src/lib/index.ts b/packages/tests/src/lib/index.ts
index d549d00d90..8f514cc61f 100644
--- a/packages/tests/src/lib/index.ts
+++ b/packages/tests/src/lib/index.ts
@@ -119,6 +119,7 @@ export class ServiceNodesFleet {
   ): Promise<void> {
     if (encryptedPayload) {
       expect(this.messageCollector.count).to.equal(numMessages);
+      return;
     }
 
     if (this.strictChecking) {
@@ -153,13 +154,14 @@ class MultipleNodesMessageCollector {
   ) {
     this.callback = (msg: DecodedMessage): void => {
       log.info("Got a message");
+      // Only add message if we haven't seen it before
       if (
-        this.messageList.find(
+        !this.messageList.find(
           (m) => m.payload.toString() === msg.payload.toString()
         )
-      )
-        return;
-      this.messageList.push(msg);
+      ) {
+        this.messageList.push(msg);
+      }
     };
   }