From 07007eadb0e36c710b0d4a7ec5a58ee436e3e430 Mon Sep 17 00:00:00 2001 From: "fryorcraken.eth" Date: Fri, 9 Sep 2022 10:32:43 +1000 Subject: [PATCH] fix: do not ignore promise in `addPeerToAddressBook` --- CHANGELOG.md | 4 ++++ src/lib/waku.ts | 6 +++--- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index f2b4835de2..43f9cdcb4f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [Unreleased] +### Changed + +- `addPeerToAddressBook` is now async. + ## [0.26.0] - 2022-09-08 ### Added diff --git a/src/lib/waku.ts b/src/lib/waku.ts index aa65878f16..ecbd90a4fd 100644 --- a/src/lib/waku.ts +++ b/src/lib/waku.ts @@ -143,10 +143,10 @@ export class WakuNode implements Waku { /** * Add peer to address book, it will be auto-dialed in the background. */ - addPeerToAddressBook( + async addPeerToAddressBook( peerId: PeerId | string, multiaddrs: Multiaddr[] | string[] - ): void { + ): Promise { let peer; if (typeof peerId === "string") { peer = peerIdFromString(peerId); @@ -160,7 +160,7 @@ export class WakuNode implements Waku { return addr; } }); - this.libp2p.peerStore.addressBook.set(peer, addresses); + await this.libp2p.peerStore.addressBook.set(peer, addresses); } async start(): Promise {