Reduce occurrences of dupe keys

This commit is contained in:
Franck Royer 2021-05-04 16:54:32 +10:00
parent 65404c769a
commit 42553202a3
No known key found for this signature in database
GPG Key ID: A82ED75A8DFC50A4
4 changed files with 41 additions and 11 deletions

View File

@ -2,7 +2,8 @@ import { multiaddr } from 'multiaddr';
import PeerId from 'peer-id'; import PeerId from 'peer-id';
import { useEffect, useState } from 'react'; import { useEffect, useState } from 'react';
import './App.css'; import './App.css';
import { ChatMessage } from 'waku/chat_message'; import { ChatMessage } from './ChatMessage';
import { ChatMessage as WakuChatMessage } from 'waku/chat_message';
import { WakuMessage } from 'waku/waku_message'; import { WakuMessage } from 'waku/waku_message';
import { RelayDefaultTopic } from 'waku/waku_relay'; import { RelayDefaultTopic } from 'waku/waku_relay';
import { StoreCodec } from 'waku/waku_store'; import { StoreCodec } from 'waku/waku_store';
@ -73,7 +74,10 @@ export default function App() {
const messages = response const messages = response
.map((wakuMsg) => wakuMsg.payload) .map((wakuMsg) => wakuMsg.payload)
.filter((payload) => !!payload) .filter((payload) => !!payload)
.map((payload) => ChatMessage.decode(payload as Uint8Array)); .map((payload) => WakuChatMessage.decode(payload as Uint8Array))
.map((wakuChatMessage) =>
ChatMessage.fromWakuChatMessage(wakuChatMessage)
);
copyMergeUniqueReplace(messages, stateMessages, setMessages); copyMergeUniqueReplace(messages, stateMessages, setMessages);
} }
} }
@ -122,7 +126,7 @@ export default function App() {
setNick setNick
); );
const commandMessages = response.map((msg) => { const commandMessages = response.map((msg) => {
return new ChatMessage(new Date(), command, msg); return new ChatMessage(new Date(), new Date(), command, msg);
}); });
copyAppendReplace(commandMessages, stateMessages, setMessages); copyAppendReplace(commandMessages, stateMessages, setMessages);
}} }}
@ -162,7 +166,9 @@ function decodeWakuMessage(data: Uint8Array): null | ChatMessage {
if (!wakuMsg.payload) { if (!wakuMsg.payload) {
return null; return null;
} }
return ChatMessage.decode(wakuMsg.payload); return ChatMessage.fromWakuChatMessage(
WakuChatMessage.decode(wakuMsg.payload)
);
} }
function copyAppendReplace<T>( function copyAppendReplace<T>(
@ -185,7 +191,7 @@ function copyMergeUniqueReplace(
copy.push(msg); copy.push(msg);
} }
}); });
copy.sort((a, b) => a.timestamp.valueOf() - b.timestamp.valueOf()); copy.sort((a, b) => a.sentTimestamp.valueOf() - b.sentTimestamp.valueOf());
setter(copy); setter(copy);
} }
@ -193,6 +199,6 @@ function isEqual(lhs: ChatMessage, rhs: ChatMessage): boolean {
return ( return (
lhs.nick === rhs.nick && lhs.nick === rhs.nick &&
lhs.message === rhs.message && lhs.message === rhs.message &&
lhs.timestamp.toString() === rhs.timestamp.toString() lhs.sentTimestamp.toString() === rhs.sentTimestamp.toString()
); );
} }

View File

@ -1,5 +1,5 @@
import { useEffect, useRef } from 'react'; import { useEffect, useRef } from 'react';
import { ChatMessage } from 'waku/chat_message'; import { ChatMessage } from './ChatMessage';
import { import {
Message, Message,
MessageText, MessageText,
@ -20,7 +20,11 @@ export default function ChatList(props: Props) {
{currentMessageGroup.map((currentMessage) => ( {currentMessageGroup.map((currentMessage) => (
<Message <Message
// We assume that the same user is not sending two messages in the same second // We assume that the same user is not sending two messages in the same second
key={currentMessage.timestamp.toString() + currentMessage.nick} key={
currentMessage.receivedTimestampMs.valueOf() +
currentMessage.nick +
currentMessage.message
}
authorName={currentMessage.nick} authorName={currentMessage.nick}
date={formatDisplayDate(currentMessage)} date={formatDisplayDate(currentMessage)}
> >
@ -58,7 +62,7 @@ function groupMessagesBySender(messageArray: ChatMessage[]): ChatMessage[][] {
} }
function formatDisplayDate(message: ChatMessage): string { function formatDisplayDate(message: ChatMessage): string {
return message.timestamp.toLocaleString([], { return message.sentTimestamp.toLocaleString([], {
month: 'short', month: 'short',
day: 'numeric', day: 'numeric',
hour: 'numeric', hour: 'numeric',

View File

@ -0,0 +1,19 @@
import { ChatMessage as WakuChatMessage } from 'waku/chat_message';
export class ChatMessage {
constructor(
public receivedTimestampMs: Date,
public sentTimestamp: Date,
public nick: string,
public message: string
) {}
static fromWakuChatMessage(wakuChatMessage: WakuChatMessage): ChatMessage {
return new ChatMessage(
new Date(),
wakuChatMessage.timestamp,
wakuChatMessage.nick,
wakuChatMessage.message
);
}
}

View File

@ -1,5 +1,6 @@
import { useState } from 'react'; import { useState } from 'react';
import { ChatMessage } from 'waku/chat_message'; import { ChatMessage } from './ChatMessage';
import { ChatMessage as WakuChatMessage } from 'waku/chat_message';
import { WakuMessage } from 'waku/waku_message'; import { WakuMessage } from 'waku/waku_message';
import { ChatContentTopic } from './App'; import { ChatContentTopic } from './App';
import ChatList from './ChatList'; import ChatList from './ChatList';
@ -52,7 +53,7 @@ async function handleMessage(
if (message.startsWith('/')) { if (message.startsWith('/')) {
commandHandler(message); commandHandler(message);
} else { } else {
const chatMessage = new ChatMessage(new Date(), nick, message); const chatMessage = new WakuChatMessage(new Date(), nick, message);
const wakuMsg = WakuMessage.fromBytes( const wakuMsg = WakuMessage.fromBytes(
chatMessage.encode(), chatMessage.encode(),
ChatContentTopic ChatContentTopic