logos-messaging/js-waku
1
0
Fork 0
mirror of https://github.com/logos-messaging/js-waku.git synced 2026-01-02 13:53:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: address review feedback for message hash tests

Browse Source 
- Remove all console.log statements (8 instances)
- Update type usage from DecodedMessage[] to IDecodedMessage[]
- Replace assert.equal() with expect().to.equal() for consistency
- Import expect from chai alongside existing imports

These changes address all feedback from PR review without altering test logic.
This commit is contained in:
Arseniy Klempner 2025-06-02 16:33:50 -07:00
parent 9f7a15dfb1
commit 2d92191029
No known key found for this signature in database
GPG Key ID: 51653F18863BD24B
1 changed files with 9 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
packages/tests/tests/store/message_hash.spec.ts
View File

@ -1,7 +1,7 @@
import { DecodedMessage } from "@waku/core"; import { DecodedMessage } from "@waku/core";
import type { LightNode } from "@waku/interfaces"; import type { IDecodedMessage, LightNode } from "@waku/interfaces";
import { messageHash } from "@waku/message-hash"; import { messageHash } from "@waku/message-hash";
import { assert } from "chai"; import { assert, expect } from "chai";
import { import {
afterEachCustom, afterEachCustom,
@ -40,14 +40,14 @@ describe("Waku Store, message hash query", function () {
true true
); );
const messages: DecodedMessage[] = []; const messages: IDecodedMessage[] = [];
for await (const page of waku.store.queryGenerator([TestDecoder])) { for await (const page of waku.store.queryGenerator([TestDecoder])) {
for await (const msg of page) { for await (const msg of page) {
messages.push(msg as DecodedMessage); messages.push(msg as IDecodedMessage);
} }
} }
assert.equal(messages.length, totalMsgs); expect(messages.length).to.equal(totalMsgs);
}); });
it("can query messages by message hash", async function () { it("can query messages by message hash", async function () {
@ -72,12 +72,7 @@ describe("Waku Store, message hash query", function () {
}) })
); );
console.log("Sent messages:", sentMessages.length); const messages: IDecodedMessage[] = [];
console.log("First message:", sentMessages[0]);
console.log("Message hashes:", messageHashes.length);
console.log("First hash:", messageHashes[0]);
const messages: DecodedMessage[] = [];
let pageCount = 0; let pageCount = 0;
try { try {
for await (const page of waku.store.queryGenerator([TestDecoder], { for await (const page of waku.store.queryGenerator([TestDecoder], {
@ -85,20 +80,16 @@ describe("Waku Store, message hash query", function () {
pubsubTopic: TestDecoder.pubsubTopic pubsubTopic: TestDecoder.pubsubTopic
})) { })) {
pageCount++; pageCount++;
console.log(`Page ${pageCount} received`);
for await (const msg of page) { for await (const msg of page) {
messages.push(msg as DecodedMessage); messages.push(msg as IDecodedMessage);
} }
} }
} catch (error) { } catch (error) {
console.error("Error during query:", error);
throw error; throw error;
} }
console.log("Total pages:", pageCount); expect(messages.length).to.equal(messageHashes.length);
console.log("Total messages received:", messages.length);
assert.equal(messages.length, messageHashes.length);
for (const msg of messages) { for (const msg of messages) {
assert.equal(msg.contentTopic, TestDecoder.contentTopic); expect(msg.contentTopic).to.equal(TestDecoder.contentTopic);
} }
}); });
}); });