From 27b17ae6856d0ea809013e4febfc378a6d42cf10 Mon Sep 17 00:00:00 2001 From: Sasha <118575614+weboko@users.noreply.github.com> Date: Wed, 20 Aug 2025 23:28:34 +0200 Subject: [PATCH] chore: remove store cursor creation --- packages/interfaces/src/store.ts | 4 ---- packages/sdk/src/store/store.ts | 13 +------------ packages/tests/tests/store/cursor.node.spec.ts | 9 ++++++--- 3 files changed, 7 insertions(+), 19 deletions(-) diff --git a/packages/interfaces/src/store.ts b/packages/interfaces/src/store.ts index 014842aaa6..a6ed913f26 100644 --- a/packages/interfaces/src/store.ts +++ b/packages/interfaces/src/store.ts @@ -1,7 +1,5 @@ import type { IDecodedMessage, IDecoder } from "./message.js"; -export type StoreCursor = Uint8Array; - /** * Parameters for a store query request, as specified in the Waku Store v3 RFC. */ @@ -77,8 +75,6 @@ export type QueryRequestParams = { export type IStore = { readonly multicodec: string; - - createCursor(message: IDecodedMessage): StoreCursor; queryGenerator: ( decoders: IDecoder[], options?: Partial diff --git a/packages/sdk/src/store/store.ts b/packages/sdk/src/store/store.ts index 1297060cf2..b5b6bb4e88 100644 --- a/packages/sdk/src/store/store.ts +++ b/packages/sdk/src/store/store.ts @@ -1,7 +1,7 @@ import type { PeerId } from "@libp2p/interface"; import { peerIdFromString } from "@libp2p/peer-id"; import { multiaddr } from "@multiformats/multiaddr"; -import { messageHash, StoreCore } from "@waku/core"; +import { StoreCore } from "@waku/core"; import { IDecodedMessage, IDecoder, @@ -9,7 +9,6 @@ import { Libp2p, Protocols, QueryRequestParams, - StoreCursor, StoreProtocolOptions } from "@waku/interfaces"; import { isDefined, Logger } from "@waku/utils"; @@ -160,16 +159,6 @@ export class Store implements IStore { return abort; } - /** - * Creates a cursor based on the provided decoded message. - * - * @param message - The decoded message. - * @returns A StoreCursor representing the message. - */ - public createCursor(message: IDecodedMessage): StoreCursor { - return messageHash(message.pubsubTopic, message); - } - /** * Validates the provided decoders and pubsub topic. * diff --git a/packages/tests/tests/store/cursor.node.spec.ts b/packages/tests/tests/store/cursor.node.spec.ts index 1a68186c45..f96d2c0375 100644 --- a/packages/tests/tests/store/cursor.node.spec.ts +++ b/packages/tests/tests/store/cursor.node.spec.ts @@ -1,4 +1,4 @@ -import { DecodedMessage } from "@waku/core"; +import { DecodedMessage, messageHash } from "@waku/core"; import type { LightNode } from "@waku/interfaces"; import { bytesToUtf8 } from "@waku/utils/bytes"; import { expect } from "chai"; @@ -65,7 +65,10 @@ describe("Waku Store, cursor", function () { } // create cursor to extract messages after the cursorIndex - const cursor = waku.store.createCursor(messages[cursorIndex]); + const cursor = messageHash( + messages[cursorIndex].pubsubTopic, + messages[cursorIndex] + ); const messagesAfterCursor: DecodedMessage[] = []; for await (const page of waku.store.queryGenerator([TestDecoder], { @@ -114,7 +117,7 @@ describe("Waku Store, cursor", function () { } // create cursor to extract messages after the cursorIndex - const cursor = waku.store.createCursor(messages[5]); + const cursor = messageHash(messages[5].pubsubTopic, messages[5]); // query node2 with the cursor from node1 const messagesAfterCursor: DecodedMessage[] = [];