From 017e90184ff5e8011fd5c03a0b0ed040db89cdcf Mon Sep 17 00:00:00 2001 From: Danish Arora Date: Tue, 8 Oct 2024 11:07:36 +0530 Subject: [PATCH] chore: remove additional arg --- packages/core/src/lib/filter/index.ts | 2 -- packages/sdk/src/protocols/filter/index.ts | 5 +---- packages/tests/tests/health-manager/node.spec.ts | 2 +- packages/tests/tests/light-push/peer_management.spec.ts | 3 ++- 4 files changed, 4 insertions(+), 8 deletions(-) diff --git a/packages/core/src/lib/filter/index.ts b/packages/core/src/lib/filter/index.ts index fdc19698a2..599b021db5 100644 --- a/packages/core/src/lib/filter/index.ts +++ b/packages/core/src/lib/filter/index.ts @@ -37,7 +37,6 @@ export class FilterCore extends BaseProtocol implements IBaseProtocolCore { wakuMessage: WakuMessage, peerIdStr: string ) => Promise, - private handleError: (error: Error) => Promise, public readonly pubsubTopics: PubsubTopic[], libp2p: Libp2p ) { @@ -313,7 +312,6 @@ export class FilterCore extends BaseProtocol implements IBaseProtocolCore { "stream ", stream ); - await this.handleError(e); } ); } catch (e) { diff --git a/packages/sdk/src/protocols/filter/index.ts b/packages/sdk/src/protocols/filter/index.ts index 67a1d31c9c..6f5320812b 100644 --- a/packages/sdk/src/protocols/filter/index.ts +++ b/packages/sdk/src/protocols/filter/index.ts @@ -51,12 +51,9 @@ class Filter extends BaseProtocolSDK implements IFilter { ); return; } - await subscription.processIncomingMessage(wakuMessage, peerIdStr); }, - async (error: Error) => { - log.error("Error with receiving pipe", error); - }, + connectionManager.configuredPubsubTopics, libp2p ), diff --git a/packages/tests/tests/health-manager/node.spec.ts b/packages/tests/tests/health-manager/node.spec.ts index f29e4d98b9..cbccb7d34e 100644 --- a/packages/tests/tests/health-manager/node.spec.ts +++ b/packages/tests/tests/health-manager/node.spec.ts @@ -17,7 +17,7 @@ import { TestShardInfo } from "./utils.js"; -describe("Node Health Status Matrix Tests", function () { +describe.only("Node Health Status Matrix Tests", function () { let waku: LightNode; let serviceNodes: ServiceNode[]; diff --git a/packages/tests/tests/light-push/peer_management.spec.ts b/packages/tests/tests/light-push/peer_management.spec.ts index d447aafbce..218e7a6a89 100644 --- a/packages/tests/tests/light-push/peer_management.spec.ts +++ b/packages/tests/tests/light-push/peer_management.spec.ts @@ -47,7 +47,8 @@ describe("Waku Light Push: Connection Management: E2E", function () { expect(failures?.length || 0).to.equal(0); }); - it("Failed peers are renewed", async function () { + // skipped because of https://github.com/waku-org/js-waku/pull/2155#discussion_r1787452696 + it.skip("Failed peers are renewed", async function () { // send a lightpush request -- should have all successes const response1 = await waku.lightPush.send( encoder,