logos-messaging/go-libp2p-pubsub
1
0
Fork 0
mirror of https://github.com/logos-messaging/go-libp2p-pubsub.git synced 2026-01-08 15:53:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

better range check for expected value in test

Browse Source
This commit is contained in:
Yusef Napora 2020-05-19 10:44:46 -04:00 committed by vyzo
parent 767692b3f6
commit d57a6c23da
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
tag_tracer_test.go
View File

@ -132,18 +132,18 @@ func TestTagTracerDeliveryTags(t *testing.T) {
clk.Add(50 * time.Minute) clk.Add(50 * time.Minute)
val = getTagValue(cmgr, p, tag1) val = getTagValue(cmgr, p, tag1)
expected = GossipSubConnTagMessageDeliveryCap - 5
// the actual expected value should be GossipSubConnTagMessageDeliveryCap - 5, // the actual expected value should be GossipSubConnTagMessageDeliveryCap - 5,
// however due to timing issues on Travis, we consistently get GossipSubConnTagMessageDeliveryCap - 4 // however due to timing issues on Travis, we consistently get GossipSubConnTagMessageDeliveryCap - 4
// there instead. // there instead. So our assertion checks for the expected value +/- 1
expected = GossipSubConnTagMessageDeliveryCap - 4 if val > expected+1 || val < expected-1 {
if val > expected {
t.Errorf("expected delivery tag value <= %d, got %d", expected, val) t.Errorf("expected delivery tag value <= %d, got %d", expected, val)
} }
// the tag for topic-2 should have reset to zero by now, but again we add one for Travis since it's slow... // the tag for topic-2 should have reset to zero by now, but again we add one for Travis since it's slow...
val = getTagValue(cmgr, p, tag2) val = getTagValue(cmgr, p, tag2)
expected = 1 expected = 0
if val > expected { if val > expected+1 || val < expected-1 {
t.Errorf("expected delivery tag value <= %d, got %d", expected, val) t.Errorf("expected delivery tag value <= %d, got %d", expected, val)
} }