logos-messaging/go-libp2p-pubsub
1
0
Fork 0
mirror of https://github.com/logos-messaging/go-libp2p-pubsub.git synced 2026-01-08 07:43:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

make tracer.Close safer

Browse Source
This commit is contained in:
vyzo 2019-11-19 00:29:23 +02:00
parent 40e5a49d1b
commit cd7f42e1d7
1 changed files with 16 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
tracer.go
View File

@ -25,14 +25,20 @@ var TraceBufferSize = 1 << 16 // 64K ought to be enough for everyone; famous las
var MinTraceBatchSize = 16 var MinTraceBatchSize = 16
type basicTracer struct { type basicTracer struct {
ch chan struct{} ch chan struct{}
mx sync.Mutex mx sync.Mutex
buf []*pb.TraceEvent buf []*pb.TraceEvent
lossy bool lossy bool
closed bool
} }
func (t *basicTracer) Trace(evt *pb.TraceEvent) { func (t *basicTracer) Trace(evt *pb.TraceEvent) {
t.mx.Lock() t.mx.Lock()
if t.closed {
t.mx.Unlock()
return
}
if t.lossy && len(t.buf) > TraceBufferSize { if t.lossy && len(t.buf) > TraceBufferSize {
log.Warningf("trace buffer overflow; dropping trace event") log.Warningf("trace buffer overflow; dropping trace event")
} else { } else {
@ -47,7 +53,12 @@ func (t *basicTracer) Trace(evt *pb.TraceEvent) {
} }
func (t *basicTracer) Close() { func (t *basicTracer) Close() {
close(t.ch) t.mx.Lock()
defer t.mx.Unlock()
if !t.closed {
t.closed = true
close(t.ch)
}
} }
// JSONTracer is a tracer that writes events to a file, encoded in ndjson. // JSONTracer is a tracer that writes events to a file, encoded in ndjson.