From 4ccb63821e80f5f05f4894f98c2f6a90e64a1894 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C3=BCdiger=20Klaehn?= Date: Fri, 24 Jul 2020 22:44:32 +0200 Subject: [PATCH] Add warning about messageIDs See https://github.com/libp2p/specs/pull/285 and https://github.com/libp2p/go-libp2p-pubsub/issues/361 --- pb/rpc.proto | 2 ++ 1 file changed, 2 insertions(+) diff --git a/pb/rpc.proto b/pb/rpc.proto index 193a632..a060fff 100644 --- a/pb/rpc.proto +++ b/pb/rpc.proto @@ -32,10 +32,12 @@ message ControlMessage { message ControlIHave { optional string topicID = 1; + // implementors from other languages should use bytes here - go protobuf emits invalid utf8 strings repeated string messageIDs = 2; } message ControlIWant { + // implementors from other languages should use bytes here - go protobuf emits invalid utf8 strings repeated string messageIDs = 1; }