From f430d6751353567d44ae63b01d7c71b6010f264b Mon Sep 17 00:00:00 2001
From: danisharora099 <danisharora099@gmail.com>
Date: Mon, 12 Dec 2022 13:57:32 +0530
Subject: [PATCH] chore: condense generation and import signature into one
 button

having two buttons:
- one for generating new credentials, then
registering on contract
- other for importing credentials that already
exist

removing two and only having one:
- generates credentials
- checks if pubKey matches in the smart contract
  - if exists, automatically hydrates
membershipId
  - if does not exist, enables action of
registering your new membershipId
---
 rln-js/index.html | 34 +++++++---------------------------
 1 file changed, 7 insertions(+), 27 deletions(-)

diff --git a/rln-js/index.html b/rln-js/index.html
index f658084..e368842 100644
--- a/rln-js/index.html
+++ b/rln-js/index.html
@@ -44,18 +44,20 @@
 
     <div class="row">
       <div class="w50">
-        <h4>You can either generate new credentials:</h4>
-        <button disabled id="generate-credentials" type="button">
-          Generate RLN Credentials
-        </button>
+        <h4>Generate new, or import existing, credentials from wallet:</h4>
         <br />
+        <div id="import-from-wallet">
+          <button id="import-from-wallet-button" type="button">
+            Fetch credentials from wallet
+          </button>
+        </div>
         <br />
         <button disabled id="register-button" type="button">
           Register Credentials in Contract
         </button>
       </div>
       <div class="w50">
-        <h4>Or import existing ones:</h4>
+        <h4>Import existing credentials manually:</h4>
         <div>
           <label for="membership-id"
             >Membership ID (your index in the RLN smart contract):</label
@@ -69,11 +71,6 @@
             Import RLN Credentials
           </button>
         </div>
-        <div id="import-from-wallet">
-          <button disabled id="import-from-wallet-button" type="button">
-            Import RLN Credentials from Wallet
-          </button>
-        </div>
       </div>
     </div>
     <div class="row rcenter mu1">
@@ -165,9 +162,6 @@
       );
 
       // Credentials Elements
-      const generateCredsButton = document.getElementById(
-        "generate-credentials"
-      );
 
       const membershipIdInput = document.getElementById("membership-id");
       const identityKeyInput = document.getElementById("id-key");
@@ -247,8 +241,6 @@
           }
         }
 
-        generateCredsButton.disabled = !rlnInstance;
-
         registerButton.disabled = !(
           membershipKey &&
           retrievedRLNEvents &&
@@ -273,18 +265,6 @@
 
       // Blockchain
 
-      generateCredsButton.onclick = async () => {
-        // sign message with ethers
-        const signer = provider.getSigner();
-
-        const signature = await signer.signMessage(signatureMessage);
-
-        // provide the signature as a seed
-        membershipKey = rlnInstance.generateSeededMembershipKey(signature);
-
-        updateFields();
-      };
-
       membershipIdInput.onchange = updateFields;
       identityKeyInput.onchange = updateFields;
       commitmentKeyInput.onchange = updateFields;