logos-co
/
staking
mirror of https://github.com/logos-co/staking.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix(StakeManager): don't allow migration initialization while migrating 

This is actually a bug that the certora prover found.
The rule `epochStaysSameOnMigration` failed because a previous
`StakeManager` could call `migrationInitialize` and change
`currentEpoch` on a next `StakeManager`, even though the next `StakeManager`
might be in migration itself (which means the `currentEpoch` is now
allowed to change).

This commit fixes this by ensure `migrationInitialize()` will revert if
the `StakeManager` already has a `migration` on going.
This commit is contained in:
r4bbit 2024-03-01 10:56:19 +01:00 committed by Ricardo Guilherme Schmidt
parent 8d09f0b2dc
commit 5cdd54a884
3 changed files with 35 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
certora/specs/StakeManagerStartMigration.spec
View File

@ -32,7 +32,8 @@ definition blockedWhenMigrating(method f) returns bool = (
f.selector == sig:unstake(uint256).selector ||
f.selector == sig:lock(uint256).selector ||
f.selector == sig:executeEpoch().selector ||
f.selector == sig:startMigration(address).selector
f.selector == sig:startMigration(address).selector ||
f.selector == sig:migrationInitialize(uint256,uint256,uint256,uint256).selector
);
definition blockedWhenNotMigrating(method f) returns bool = (
@ -116,8 +117,9 @@ rule migrationLockedIn(method f) filtered {
assert currentContract.migration != 0;
}
rule epochStaysSameOnMigration {
method f;
rule epochStaysSameOnMigration(method f) filtered {
f -> !blockedWhenMigrating(f) && f.contract == currentContract
} {
env e;
calldataarg args;

3
contracts/StakeManager.sol
View File

@ -251,6 +251,9 @@ contract StakeManager is Ownable {
external
onlyOldManager
{
if (address(migration) != address(0)) {
revert StakeManager__PendingMigration();
}
currentEpoch = _currentEpoch;
totalSupplyMP = _totalSupplyMP;
totalSupplyBalance = _totalSupplyBalance;

27
test/StakeManager.t.sol
View File

@ -273,6 +273,33 @@ contract MigrateTest is StakeManagerTest {
}
}
contract MigrationInitializeTest is StakeManagerTest {
function setUp() public override {
StakeManagerTest.setUp();
}
function test_RevertWhen_MigrationPending() public {
// first, create 2nd and 3rd generation stake manager
vm.startPrank(deployer);
StakeManager secondStakeManager = new StakeManager(stakeToken, address(stakeManager));
StakeManager thirdStakeManager = new StakeManager(stakeToken, address(secondStakeManager));
// first, ensure `secondStakeManager` is in migration mode itself
secondStakeManager.startMigration(thirdStakeManager);
vm.stopPrank();
uint256 currentEpoch = stakeManager.currentEpoch();
uint256 totalMP = stakeManager.totalSupplyMP();
uint256 totalBalance = stakeManager.totalSupplyBalance();
// `stakeManager` calling `migrationInitialize` while the new stake manager is
// in migration itself, should revert
vm.prank(address(stakeManager));
vm.expectRevert(StakeManager.StakeManager__PendingMigration.selector);
secondStakeManager.migrationInitialize(currentEpoch, totalMP, totalBalance, 0);
}
}
contract ExecuteAccountTest is StakeManagerTest {
StakeVault[] private userVaults;