logos-co/nomos-specs
1
0
Fork 0
mirror of https://github.com/logos-co/nomos-specs.git synced 2025-02-08 21:43:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

add informative comments and remove panic

Browse Source
This commit is contained in:
Giacomo Pasini 2023-04-27 15:41:25 +02:00
parent 8b67c30ba9
commit e868a4599b
No known key found for this signature in database
GPG Key ID: FC08489D2D895D4B
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
carnot/carnot.py
View File

@ -354,6 +354,8 @@ class Carnot:
# By rejecting any other blocks except the first one received for a view this code does NOT do that. # By rejecting any other blocks except the first one received for a view this code does NOT do that.
return return
# TODO: check the proposer of the block is indeed leader for that view
if self.block_is_safe(block): if self.block_is_safe(block):
self.safe_blocks[block.id()] = block self.safe_blocks[block.id()] = block
self.update_high_qc(block.qc) self.update_high_qc(block.qc)
@ -555,8 +557,11 @@ class Carnot:
# Just a suggestion that received_timeout_qc can be reused by each node when the process timeout_qc of the NewView msg. # Just a suggestion that received_timeout_qc can be reused by each node when the process timeout_qc of the NewView msg.
# TODO: check that receiving (and processing) a timeout qc "in the future" allows to process old(er) blocks
# e.g. we might still need access to the old leader schedule to validate qcs
def receive_timeout_qc(self, timeout_qc: TimeoutQc): def receive_timeout_qc(self, timeout_qc: TimeoutQc):
assert timeout_qc.view >= self.current_view if timeout_qc.view < self.current_view:
return
new_high_qc = timeout_qc.high_qc new_high_qc = timeout_qc.high_qc
self.update_high_qc(new_high_qc) self.update_high_qc(new_high_qc)
self.update_timeout_qc(timeout_qc) self.update_timeout_qc(timeout_qc)