logos-co/nomos-specs
1
0
Fork 0
mirror of https://github.com/logos-co/nomos-specs.git synced 2025-02-02 10:34:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add clarifying comment to forward_vote (#38)

Browse Source
This commit is contained in:
Giacomo Pasini 2023-11-02 10:40:30 +01:00 committed by GitHub
parent f635996d10
commit 6f0e8a95c0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
carnot/carnot.py
View File

@ -392,6 +392,12 @@ class Carnot:
return Send(to=self.overlay.parent_committee(self.id), payload=vote)
def forward_vote(self, vote: Vote) -> Optional[Event]:
"""
Recall that for the leader to propose a block it's necessary to have a threshold of the top three committees
votes. In case part of the root committee is malicious and does not vote, the leader might not reach this threshold
even though more than 2/3 of the total nodes voted in favor if nodes stop sending votes after the threshold.
By forwarding votes from children (only the root committee does this), we can improve liveness in this case.
"""
assert vote.block in self.safe_blocks
assert self.overlay.is_member_of_child_committee(self.id, vote.voter)
# we only forward votes after we've voted ourselves