logos-co
/
nomos-specs
mirror of https://github.com/logos-co/nomos-specs.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Comments for read and write methods in BlobStore

This commit is contained in:
Gusto 2024-03-14 15:33:29 +02:00
parent 1a75c2d34b
commit 484f4daa2d
No known key found for this signature in database
2 changed files with 17 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
da/api/common.py
View File

@ -22,11 +22,20 @@ class Api:
def __init__(self, bs: BlobStore): def __init__(self, bs: BlobStore):
self.store = bs self.store = bs
"""
Write method should be used by a service that is able to retrieve verified certificates
from the latest Block. Once a certificate is retrieved, api creates a relation between
the blob of an original data, certificate and index for the app_id of the certificate.
"""
def write(self, certificate, metadata): def write(self, certificate, metadata):
# TODO: Certificate indexing can fail.
self.store.add(certificate, metadata) self.store.add(certificate, metadata)
return return
"""
Read method should accept only `app_id` and a list of indexes. The returned list of
blobs should be ordered in the same sequence as `indexes` in a request.
If node does not have the blob for some indexes, then it should add None object as an
item.
"""
def read(self, app_id, indexes) -> Optional[List[Optional[DABlob]]]: def read(self, app_id, indexes) -> Optional[List[Optional[DABlob]]]:
# Gather requested indexes for the app_id.
return self.store.get_multiple(app_id, indexes) return self.store.get_multiple(app_id, indexes)

11
da/api/test_flow.py
View File

@ -15,7 +15,7 @@ class MockStore(BlobStore):
def populate(self, blob, cert_id: bytes): def populate(self, blob, cert_id: bytes):
self.blob_store[cert_id] = blob self.blob_store[cert_id] = blob
# cert, app_id, idx # Implements `add` method from BlobStore abstract class.
def add(self, cert_id: bytes, metadata: Metadata): def add(self, cert_id: bytes, metadata: Metadata):
if metadata.index in self.app_id_store[metadata.app_id]: if metadata.index in self.app_id_store[metadata.app_id]:
raise ValueError("index already written") raise ValueError("index already written")
@ -23,6 +23,7 @@ class MockStore(BlobStore):
blob = self.blob_store.pop(cert_id) blob = self.blob_store.pop(cert_id)
self.app_id_store[metadata.app_id][metadata.index] = blob self.app_id_store[metadata.app_id][metadata.index] = blob
# Implements `get_multiple` method from BlobStore abstract class.
def get_multiple(self, app_id, indexes) -> List[Optional[DABlob]]: def get_multiple(self, app_id, indexes) -> List[Optional[DABlob]]:
return [ return [
self.app_id_store[app_id].get(i) for i in indexes self.app_id_store[app_id].get(i) for i in indexes
@ -43,9 +44,9 @@ class TestFlow(TestCase):
api = Api(mock_store) api = Api(mock_store)
api.write(cert_id, mock_meta) api.write(cert_id, mock_meta)
blob = api.read(app_id, [idx]) blobs = api.read(app_id, [idx])
self.assertEqual([expected_blob], blob) self.assertEqual([expected_blob], blobs)
def test_same_index(self): def test_same_index(self):
expected_blob = "hello" expected_blob = "hello"
@ -63,7 +64,7 @@ class TestFlow(TestCase):
with self.assertRaises(ValueError): with self.assertRaises(ValueError):
api.write(cert_id, mock_meta) api.write(cert_id, mock_meta)
blob = api.read(app_id, [idx]) blobs = api.read(app_id, [idx])
self.assertEqual([expected_blob], blob) self.assertEqual([expected_blob], blobs)