From c1ec5e54df920a1e1ec47f6eaaac51d6c44bc030 Mon Sep 17 00:00:00 2001
From: Roman <zajic@zajic.net>
Date: Tue, 25 Jun 2024 14:20:38 +0200
Subject: [PATCH] fix: refactor error cases into more tests

---
 ledger/cryptarchia-ledger/src/lib.rs | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

diff --git a/ledger/cryptarchia-ledger/src/lib.rs b/ledger/cryptarchia-ledger/src/lib.rs
index 8e2da3e7..497c1949 100644
--- a/ledger/cryptarchia-ledger/src/lib.rs
+++ b/ledger/cryptarchia-ledger/src/lib.rs
@@ -773,7 +773,7 @@ pub mod tests {
     }
 
     #[test]
-    fn test_cryptarchia_ledger_error_cases() {
+    fn test_update_epoch_state_with_outdated_slot_error() {
         let coin = coin(0);
         let commitment = coin.commitment();
         let (ledger, genesis) = ledger(&[commitment]);
@@ -797,8 +797,17 @@ pub mod tests {
                 if parent == slot && block == slot2 => {}
             _ => panic!("error does not match the LedgerError::InvalidSlot pattern"),
         };
+    }
+
+    #[test]
+    fn test_apply_proof_with_existing_commitment_error() {
+        let coin = coin(0);
+        let commitment = coin.commitment();
+        let (ledger, genesis) = ledger(&[commitment]);
 
         let ledger_state = ledger.state(&genesis).unwrap().clone();
+        let ledger_config = ledger.config();
+
         let actual_slot = ledger_state.slot();
         let proof = LeaderProof::dummy(actual_slot, commitment, commitment);
         let epoch_state = ledger_state.epoch_state();
@@ -814,7 +823,7 @@ pub mod tests {
             .try_apply_proof::<HeaderId>(&proof, ledger_config)
             .err();
 
-        // Commitment cannot be spent twice
+        // Same commitment value from another coin cannot be used again
         assert!(
             matches!(apply_proof_err, Some(LedgerError::CommitmentExists)),
             "Error does not match LedgerError::CommitmentExists"