test: use port_bindings

This commit is contained in:
Roman 2024-12-20 18:14:43 +08:00
parent 75874da44b
commit 35dff2cdb2
No known key found for this signature in database
GPG Key ID: B8FE070B54E11B75
2 changed files with 5 additions and 5 deletions

View File

@ -35,7 +35,7 @@ class DockerManager:
logger.debug(f"Network {network_name} created")
return network
def start_container(self, image_name, ports, args, log_path, container_ip, volumes, remove_container=True):
def start_container(self, image_name, port_bindings, args, log_path, container_ip, volumes, remove_container=True):
cli_args = []
for key, value in args.items():
if isinstance(value, list): # Check if value is a list
@ -45,10 +45,10 @@ class DockerManager:
else:
cli_args.append(f"--{key}={value}") # Add a single command
port_bindings = {f"{port}/tcp": ("", port) for port in ports}
port_bindings_for_log = " ".join(f"-p {port}:{port}" for port in ports)
# port_bindings = {f"{port}/tcp": ("", port) for port in ports}
# port_bindings_for_log = " ".join(f"-p {port}:{port}" for port in ports)
cli_args_str_for_log = " ".join(cli_args)
logger.debug(f"docker run -i -t {port_bindings_for_log} {image_name} {cli_args_str_for_log}")
logger.debug(f"docker run -i -t {port_bindings} {image_name} {cli_args_str_for_log}")
container = self._client.containers.run(
image_name, command=cli_args, ports=port_bindings, detach=True, remove=remove_container, auto_remove=remove_container, volumes=volumes
)

View File

@ -66,7 +66,7 @@ class NomosNode:
self._container = self._docker_manager.start_container(
self._docker_manager.image,
ports=self._port_map,
port_bindings=self._port_map,
args=default_args,
log_path=self._log_path,
container_ip=self._ext_ip,